Attachment 26092 Details for Bug 58152

[patch] cpio.diff

cpio.diff (text/plain), 1.06 KB, created by Thomas Biege on 2004-11-15 20:26:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Thomas Biege

Created: 2004-11-15 20:26:02 UTC

Size: 1.06 KB

patch

obsolete

>--- cpio.orig	2004-11-15 12:54:16.000000000 +0100
>+++ cpio	2004-11-15 13:22:21.000000000 +0100
>@@ -47,9 +47,7 @@
> # $2 is a name of a file within the archive
> # $3 is a name of a file within the system (to add from or extract to)
> {
>-    TMPDIR=/tmp/mctmpdir.$$
>-# FIXME bugzilla.eazel.com 1225: Try harder to generate a unique directory if this fails
>-    mkdir -m 0700 $TMPDIR || exit 1
>+    TMPDIR=$(mktemp -t -d mctmpdir.XXXXXX) || exit 1
>     cd $TMPDIR
>     uni_cat "$1" | cpio -icumd "$2" 2>/dev/null
>     mv "$2" "$3"
>@@ -62,6 +60,26 @@
> #
>     umask 077
> 
>+    # XXX thomas: white list filter for arguments
>+    if ! [ -z "$2" ]
>+        CHECK=${2//[0-9a-zA-Z]/}
>+        if ! [ "$CHECK" = "" ]; then
>+            exit 1
>+        fi
>+    fi
>+    if ! [ -z "$3" ]
>+        CHECK=${3//[0-9a-zA-Z]/}
>+        if ! [ "$CHECK" = "" ]; then
>+            exit 1
>+        fi
>+    fi
>+    if ! [ -z "$4" ]
>+        CHECK=${4//[0-9a-zA-Z]/}
>+        if ! [ "$CHECK" = "" ]; then
>+            exit 1
>+        fi
>+    fi
>+
>     case "$1" in
>     list)   mccpiofs_list $2
> 	    exit 0

Actions: View | Diff

Attachments on bug 58152: 22302 | 26091 | 26092