Attachment 27420 Details for Bug 63989

[patch] subversion.viewcvs.forbidden-hide_cvsroot.patch

subversion.viewcvs.forbidden-hide_cvsroot.patch (text/plain), 1.30 KB, created by Olaf Hering on 2005-01-06 18:46:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Olaf Hering

Created: 2005-01-06 18:46:17 UTC

Size: 1.30 KB

patch

obsolete

>Index: lib/viewcvs.py
>===================================================================
>RCS file: /cvsroot/viewcvs/viewcvs/lib/viewcvs.py,v
>retrieving revision 1.309
>diff -u -p -r1.309 viewcvs.py
>--- lib/viewcvs.py	10 Dec 2004 02:09:46 -0000	1.309
>+++ lib/viewcvs.py	6 Jan 2005 10:31:17 -0000
>@@ -2630,11 +2630,13 @@ def generate_tarball_header(out, name, s
> def generate_tarball(out, request, tar_top, rep_top,
>                      reldir, options, stack=[]):
>   cvs = request.roottype == 'cvs'
>-  if cvs and (rep_top == '' and 0 < len(reldir) and
>-              reldir[0] == 'CVSROOT' and cfg.options.hide_cvsroot):
>+  if (0 < len(rep_top) and rep_top[0] == 'CVSROOT' and cfg.options.hide_cvsroot):
>     return
> 
>-  if (rep_top == '' and cfg.is_forbidden(reldir[0])):
>+  if (0 < len(reldir) and reldir[0] == 'CVSROOT' and cfg.options.hide_cvsroot):
>+    return
>+
>+  if (rep_top == [] and 0 < len(reldir) and cfg.is_forbidden(reldir[0])):
>     return
> 
>   rep_path = rep_top + reldir
>@@ -2710,6 +2712,9 @@ def download_tarball(request):
>   rep_top = request.path_parts
>   if len(rep_top):
>     tar_top = rep_top[-1]
>+    if cfg.is_forbidden(tar_top):
>+      raise debug.ViewCVSException('Access to "%s" is forbidden.'
>+                                  % tar_top, '403 Forbidden')
>   else:
>     tar_top = request.rootname
>

Actions: View | Diff

Attachments on bug 63989: 27420 | 27441