Attachment 32741 Details for Bug 72801

[patch] sylpheed-claws-0.9.12-mimedecoding-sec.diff

sylpheed-claws-0.9.12-mimedecoding-sec.diff (text/plain), 8.03 KB, created by Thomas Biege on 2005-03-24 12:45:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Thomas Biege

Created: 2005-03-24 12:45:49 UTC

Size: 8.03 KB

patch

obsolete

>diff -ur sylpheed-claws-0.9.12.orig/src/codeconv.c sylpheed-claws-0.9.12.sec/src/codeconv.c
>--- sylpheed-claws-0.9.12.orig/src/codeconv.c	2004-06-28 18:03:21.000000000 +0200
>+++ sylpheed-claws-0.9.12.sec/src/codeconv.c	2005-03-23 14:31:20.000000000 +0100
>@@ -1450,7 +1450,7 @@
> 	return cur_locale;
> }
> 
>-void conv_unmime_header_overwrite(gchar *str)
>+void conv_unmime_header_overwrite(gchar *str, size_t strsize)
> {
> 	gchar *buf;
> 	gint buflen;
>@@ -1464,12 +1464,12 @@
> 		buflen = strlen(str) * 2 + 1;
> 		Xalloca(buf, buflen, return);
> 		conv_anytodisp(buf, buflen, str);
>-		unmime_header(str, buf);
>+		unmime_header(str, buf, strsize);
> 	} else {
> 		buflen = strlen(str) + 1;
> 		Xalloca(buf, buflen, return);
>-		unmime_header(buf, str);
>-		strncpy2(str, buf, buflen);
>+		unmime_header(buf, str, buflen);
>+		strncpy2(str, buf, strsize);
> 	}
> }
> 
>@@ -1478,6 +1478,8 @@
> {
> 	CharSet cur_charset;
> 
>+	g_return_if_fail(str != NULL);
>+
> 	cur_charset = conv_get_current_charset();
> 
> 	if (cur_charset == C_EUC_JP) {
>@@ -1487,9 +1489,9 @@
> 		buflen = strlen(str) * 2 + 1;
> 		Xalloca(buf, buflen, return);
> 		conv_anytodisp(buf, buflen, str);
>-		unmime_header(outbuf, buf);
>+		unmime_header(outbuf, buf, outlen);
> 	} else
>-		unmime_header(outbuf, str);
>+		unmime_header(outbuf, str, outlen);
> }
> 
> #define MAX_LINELEN		76
>diff -ur sylpheed-claws-0.9.12.orig/src/codeconv.h sylpheed-claws-0.9.12.sec/src/codeconv.h
>--- sylpheed-claws-0.9.12.orig/src/codeconv.h	2004-06-28 18:03:21.000000000 +0200
>+++ sylpheed-claws-0.9.12.sec/src/codeconv.h	2005-03-23 09:48:55.000000000 +0100
>@@ -216,7 +216,7 @@
> 
> const gchar *conv_get_current_locale		(void);
> 
>-void conv_unmime_header_overwrite	(gchar		*str);
>+void conv_unmime_header_overwrite	(gchar		*str, size_t strsize);
> void conv_unmime_header			(gchar		*outbuf,
> 					 gint		 outlen,
> 					 const gchar	*str,
>diff -ur sylpheed-claws-0.9.12.orig/src/compose.c sylpheed-claws-0.9.12.sec/src/compose.c
>--- sylpheed-claws-0.9.12.orig/src/compose.c	2004-06-28 18:03:21.000000000 +0200
>+++ sylpheed-claws-0.9.12.sec/src/compose.c	2005-03-23 12:39:07.000000000 +0100
>@@ -1595,12 +1595,12 @@
> 	fclose(fp);
> 
> 	if (hentry[H_REPLY_TO].body != NULL) {
>-		conv_unmime_header_overwrite(hentry[H_REPLY_TO].body);
>+		conv_unmime_header_overwrite(hentry[H_REPLY_TO].body, strlen(hentry[H_REPLY_TO].body));
> 		compose->replyto = hentry[H_REPLY_TO].body;
> 		hentry[H_REPLY_TO].body = NULL;
> 	}
> 	if (hentry[H_CC].body != NULL) {
>-		conv_unmime_header_overwrite(hentry[H_CC].body);
>+		conv_unmime_header_overwrite(hentry[H_CC].body, strlen(hentry[H_CC].body));
> 		compose->cc = hentry[H_CC].body;
> 		hentry[H_CC].body = NULL;
> 	}
>@@ -1616,19 +1616,19 @@
> 	}
> 	if (hentry[H_BCC].body != NULL) {
> 		if (compose->mode == COMPOSE_REEDIT) {
>-			conv_unmime_header_overwrite(hentry[H_BCC].body);
>+			conv_unmime_header_overwrite(hentry[H_BCC].body, strlen(hentry[H_BCC].body));
> 			compose->bcc = hentry[H_BCC].body;
> 		} else
> 			g_free(hentry[H_BCC].body);
> 		hentry[H_BCC].body = NULL;
> 	}
> 	if (hentry[H_NEWSGROUPS].body != NULL) {
>-		conv_unmime_header_overwrite(hentry[H_NEWSGROUPS].body);
>+		conv_unmime_header_overwrite(hentry[H_NEWSGROUPS].body, strlen(hentry[H_NEWSGROUPS].body));
> 		compose->newsgroups = hentry[H_NEWSGROUPS].body;
> 		hentry[H_NEWSGROUPS].body = NULL;
> 	}
> 	if (hentry[H_FOLLOWUP_TO].body != NULL) {
>-		conv_unmime_header_overwrite(hentry[H_FOLLOWUP_TO].body);
>+		conv_unmime_header_overwrite(hentry[H_FOLLOWUP_TO].body, strlen(hentry[H_FOLLOWUP_TO].body));
> 		compose->followup_to = hentry[H_FOLLOWUP_TO].body;
> 		hentry[H_FOLLOWUP_TO].body = NULL;
> 	}
>diff -ur sylpheed-claws-0.9.12.orig/src/procmime.c sylpheed-claws-0.9.12.sec/src/procmime.c
>--- sylpheed-claws-0.9.12.orig/src/procmime.c	2004-06-28 18:03:22.000000000 +0200
>+++ sylpheed-claws-0.9.12.sec/src/procmime.c	2005-03-23 10:22:23.000000000 +0100
>@@ -996,11 +996,11 @@
> 	fseek(fp, mimeinfo->offset, SEEK_SET);
> 	procheader_get_header_fields(fp, hentry);
> 	if (hentry[0].body != NULL)
>-		conv_unmime_header_overwrite(hentry[0].body);
>+		conv_unmime_header_overwrite(hentry[0].body, strlen(hentry[0].body));
> 	if (hentry[2].body != NULL)
>-		conv_unmime_header_overwrite(hentry[2].body);
>+		conv_unmime_header_overwrite(hentry[2].body, strlen(hentry[2].body));
> 	if (hentry[4].body != NULL)
>-		conv_unmime_header_overwrite(hentry[4].body);
>+		conv_unmime_header_overwrite(hentry[4].body, strlen(hentry[4].body));
> 	content_start = ftell(fp);
> 	fclose(fp);
> 
>@@ -1086,11 +1086,11 @@
> 			}
> 			procheader_get_header_fields(fp, hentry);
> 			if (hentry[0].body != NULL)
>-				conv_unmime_header_overwrite(hentry[0].body);
>+				conv_unmime_header_overwrite(hentry[0].body, strlen(hentry[0].body));
> 			if (hentry[2].body != NULL)
>-				conv_unmime_header_overwrite(hentry[2].body);
>+				conv_unmime_header_overwrite(hentry[2].body, strlen(hentry[2].body));
> 			if (hentry[4].body != NULL)
>-				conv_unmime_header_overwrite(hentry[4].body);
>+				conv_unmime_header_overwrite(hentry[4].body, strlen(hentry[4].body));
> 			lastoffset = ftell(fp);
> 		}
> 	}
>diff -ur sylpheed-claws-0.9.12.orig/src/unmime.c sylpheed-claws-0.9.12.sec/src/unmime.c
>--- sylpheed-claws-0.9.12.orig/src/unmime.c	2004-06-28 18:03:20.000000000 +0200
>+++ sylpheed-claws-0.9.12.sec/src/unmime.c	2005-03-23 14:19:16.000000000 +0100
>@@ -34,7 +34,7 @@
> 
> /* Decodes headers based on RFC2045 and RFC2047. */
> 
>-void unmime_header(gchar *out, const gchar *str)
>+void unmime_header(gchar *out, const gchar *str, size_t outsize)
> {
> 	const gchar *p = str;
> 	gchar *outp = out;
>@@ -44,34 +44,39 @@
> 	gchar encoding;
> 	gchar *conv_str;
> 	gint len;
>+	size_t cnt;
> 
>-	while (*p != '\0') {
>+	cnt = 0;
>+	while (*p != '\0' && cnt < outsize) {
> 		gchar *decoded_text = NULL;
> 
> 		eword_begin_p = strstr(p, ENCODED_WORD_BEGIN);
> 		if (!eword_begin_p) {
>-			strcpy(outp, p);
>+			strncpy(outp, p, outsize);
> 			return;
> 		}
> 		encoding_begin_p = strchr(eword_begin_p + 2, '?');
> 		if (!encoding_begin_p) {
>-			strcpy(outp, p);
>+			strncpy(outp, p, outsize);
> 			return;
> 		}
> 		text_begin_p = strchr(encoding_begin_p + 1, '?');
> 		if (!text_begin_p) {
>-			strcpy(outp, p);
>+			strncpy(outp, p, outsize);
> 			return;
> 		}
> 		eword_end_p = strstr(text_begin_p + 1, ENCODED_WORD_END);
> 		if (!eword_end_p) {
>-			strcpy(outp, p);
>+			strncpy(outp, p, outsize);
> 			return;
> 		}
> 
> 		if (p == str) {
>+			if((eword_begin_p - p) >= outsize)
>+				return;
> 			memcpy(outp, p, eword_begin_p - p);
> 			outp += eword_begin_p - p;
>+			outsize -= (eword_begin_p - p);
> 			p = eword_begin_p;
> 		} else {
> 			/* ignore spaces between encoded words */
>@@ -79,8 +84,11 @@
> 
> 			for (sp = p; sp < eword_begin_p; sp++) {
> 				if (!isspace(*(const guchar *)sp)) {
>+					if((eword_begin_p - p) >= outsize)
>+						return;
> 					memcpy(outp, p, eword_begin_p - p);
> 					outp += eword_begin_p - p;
>+					outsize -= (eword_begin_p - p);
> 					p = eword_begin_p;
> 					break;
> 				}
>@@ -106,8 +114,11 @@
> 				(decoded_text, text_begin_p + 1,
> 				 eword_end_p - (text_begin_p + 1));
> 		} else {
>+			if((eword_end_p + 2 - p) >= outsize)
>+				return;
> 			memcpy(outp, p, eword_end_p + 2 - p);
> 			outp += eword_end_p + 2 - p;
>+			outsize -= (eword_end_p + 2 - p);
> 			p = eword_end_p + 2;
> 			continue;
> 		}
>@@ -116,13 +127,25 @@
> 		conv_str = conv_codeset_strdup(decoded_text, charset, NULL);
> 		if (conv_str) {
> 			len = strlen(conv_str);
>+			if(len >= outsize)
>+			{
>+				g_free(decoded_text);
>+				g_free(conv_str);
>+				return;
>+			}
> 			memcpy(outp, conv_str, len);
> 			g_free(conv_str);
> 		} else {
> 			len = strlen(decoded_text);
>+			if(len >= outsize)
>+			{
>+				g_free(decoded_text);
>+				return;
>+			}
> 			conv_localetodisp(outp, len + 1, decoded_text);
> 		}
> 		outp += len;
>+		outsize -= len;
> 
> 		g_free(decoded_text);
> 
>diff -ur sylpheed-claws-0.9.12.orig/src/unmime.h sylpheed-claws-0.9.12.sec/src/unmime.h
>--- sylpheed-claws-0.9.12.orig/src/unmime.h	2004-06-28 18:03:20.000000000 +0200
>+++ sylpheed-claws-0.9.12.sec/src/unmime.h	2005-03-23 14:02:36.000000000 +0100
>@@ -23,7 +23,8 @@
> #include <glib.h>
> 
> void unmime_header			(gchar		*out,
>-					 const gchar	*str);
>+					 const gchar	*str,
>+					size_t		outsize);
> gint unmime_quoted_printable_line	(gchar		*str);
> 
> #endif /* __UNMIME_H__ */

Actions: View | Diff

Attachments on bug 72801: 32650 | 32677 | 32741 | 32961 | 32965 | 32969 | 32979 | 33475