Attachment 452988 Details for Bug 697929

[patch] A fix for inverted link return value test

0001-Fixed-inverted-link-ready-return-value-test.patch (text/plain), 1.35 KB, created by Marius Tomaschewski on 2011-09-26 12:48:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marius Tomaschewski

Created: 2011-09-26 12:48:06 UTC

Size: 1.35 KB

patch

obsolete

>From 8fed34d78851f6fba1c6451e74cba6c9772b157e Mon Sep 17 00:00:00 2001
>From: Marius Tomaschewski <mt@suse.com>
>Date: Mon, 26 Sep 2011 14:32:25 +0200
>Subject: [PATCH] Fixed inverted link ready return value test
>
>
>Signed-off-by: Marius Tomaschewski <mt@suse.com>
>---
> scripts/ifup |    8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/scripts/ifup b/scripts/ifup
>index 08ea71a..ba1e4f5 100755
>--- a/scripts/ifup
>+++ b/scripts/ifup
>@@ -1162,11 +1162,11 @@ case "$BOOTPROTO$SKIP_MAIN_PART" in
> 						if [ "$BOOTING" = yes -a "$RUN_FROM_RC" = yes ] ; then
> 							link_ready_check "$INTERFACE"
> 							link_ret=$?
>-							test "$link_ret" && retcode=$R_DHCP_BG
>+							test "$link_ret" -eq 0 || retcode=$R_DHCP_BG
> 						else
> 							link_ready_wait "$INTERFACE" "${LINK_READY_WAIT}"
> 							link_ret=$?
>-							test "$link_ret" && retcode=$R_NOTRUNNING
>+							test "$link_ret" -eq 0 || retcode=$R_NOTRUNNING
> 						fi
> 					fi
> 				fi
>@@ -1241,9 +1241,9 @@ case "$BOOTPROTO$SKIP_MAIN_PART" in
> 						link_ready_check "$INTERFACE"
> 						link_ret=$?
> 						if [ "$BOOTING" = yes -a "$RUN_FROM_RC" = yes ] ; then
>-							test "$link_ret" && retcode=$R_DHCP_BG
>+							test "$link_ret" -eq 0 || retcode=$R_DHCP_BG
> 						else
>-							test "$link_ret" && retcode=$R_NOTRUNNING
>+							test "$link_ret" -eq 0 || retcode=$R_NOTRUNNING
> 						fi
> 					fi
> 
>-- 
>1.7.3.4
>

Actions: View | Diff

Attachments on bug 697929: 451318 | 452941 | 452988