Attachment 45687 Details for Bug 104069

[patch] Patch for adding ',' and ';' as additional delimiter characters

radeon_mga_sis_metamodes.diff (text/plain), 10.39 KB, created by Matthias Hopf on 2005-08-11 10:02:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Matthias Hopf

Created: 2005-08-11 10:02:25 UTC

Size: 10.39 KB

patch

obsolete

>Index: programs/Xserver/hw/xfree86/drivers/mga/mga_merge.c
>===================================================================
>RCS file: /cvs/xorg/xc/programs/Xserver/hw/xfree86/drivers/mga/mga_merge.c,v
>retrieving revision 1.4
>diff -u -p -b -r1.4 mga_merge.c
>--- programs/Xserver/hw/xfree86/drivers/mga/mga_merge.c	11 Jul 2005 02:29:51 -0000	1.4
>+++ programs/Xserver/hw/xfree86/drivers/mga/mga_merge.c	10 Aug 2005 18:31:25 -0000
>@@ -151,6 +151,8 @@ GenerateModeList(ScrnInfoPtr pScrn, char
>             case 0:
>             case '-':
>             case ' ':
>+	    case ',':
>+	    case ';':
>                 if((strmode != str)) {/*we got a mode */
>                     /* read new entry */
>                     strncpy(modename,strmode,str - strmode);
>@@ -174,11 +176,11 @@ GenerateModeList(ScrnInfoPtr pScrn, char
>                                 "Mode: \"%s\" is not a supported mode for monitor 1\n",modename);
>                             /* find if a monitor2 mode follows */
>                             gotdash = FALSE;
>-                            while(*tmps == ' ') tmps++;
>-                            if(*tmps == '-') { /* skip the next mode */
>+                            while(*tmps == ' ' || *tmps == ';') tmps++;
>+                            if(*tmps == '-' || *tmps == ',') { /* skip the next mode */
>                                 tmps++;
>-                                while((*tmps == ' ') && (*tmps != 0)) tmps++; /*skip spaces */
>-                                while((*tmps != ' ') && (*tmps != '-') && (*tmps != 0)) tmps++; /*skip modename */
>+                                while(*tmps == ' ' || *tmps == ';') tmps++; /*skip spaces */
>+                                while(*tmps && *tmps != ' ' && *tmps != ';' && *tmps != '-' && *tmps != ',') tmps++; /*skip modename */
>                                 /* for error message */
>                                 strncpy(modename,strmode,tmps - strmode);
>                                 modename[tmps - strmode] = 0;
>@@ -192,7 +194,7 @@ GenerateModeList(ScrnInfoPtr pScrn, char
>                     gotdash = FALSE;
>                 }
>                 strmode = str+1; /* number starts on next char */
>-                gotdash |= (*str == '-');
>+                gotdash |= (*str == '-' || *str == ',');
>                 
>                 if(*str != 0) break; /* if end of string, we wont get a chance to catch a char and run the
>                                         default case. do it now */
>Index: programs/Xserver/hw/xfree86/drivers/ati/radeon_mergedfb.c
>===================================================================
>RCS file: /cvs/xorg/xc/programs/Xserver/hw/xfree86/drivers/ati/radeon_mergedfb.c,v
>retrieving revision 1.12
>diff -u -p -b -r1.12 radeon_mergedfb.c
>--- programs/Xserver/hw/xfree86/drivers/ati/radeon_mergedfb.c	11 Jul 2005 02:29:45 -0000	1.12
>+++ programs/Xserver/hw/xfree86/drivers/ati/radeon_mergedfb.c	10 Aug 2005 18:31:26 -0000
>@@ -413,7 +413,8 @@ RADEONGenerateModeListFromMetaModes(Scrn
> {
>     char* strmode = str;
>     char modename[256];
>-    Bool gotdash = FALSE, gotplus = FALSE;
>+    Bool gotdash = FALSE;
>+    char gotsep = 0;
>     RADEONScrn2Rel sr;
>     DisplayModePtr mode1 = NULL;
>     DisplayModePtr mode2 = NULL;
>@@ -429,6 +430,8 @@ RADEONGenerateModeListFromMetaModes(Scrn
>         case '-':
> 	case '+':
>         case ' ':
>+	case ',':
>+	case ';':
>            if(strmode != str) {
> 
>               myslen = str - strmode;
>@@ -447,9 +450,9 @@ RADEONGenerateModeListFromMetaModes(Scrn
>                     xf86DrvMsg(pScrn->scrnIndex, X_WARNING,
>                         "Mode \"%s\" is not a supported mode for CRT2\n", modename);
>                     xf86DrvMsg(pScrn->scrnIndex, X_WARNING,
>-                        "\t(Skipping metamode \"%s%s%s\")\n", mode1->name, gotplus ? "+" : "-", modename);
>+                        "\t(Skipping metamode \"%s%c%s\")\n", mode1->name, gotsep, modename);
>                     mode1 = NULL;
>-		    gotplus = FALSE;
>+		    gotsep = 0;
>                  }
>               } else {
>                  mode1 = RADEONGetModeFromName(modename, i);
>@@ -457,14 +460,14 @@ RADEONGenerateModeListFromMetaModes(Scrn
>                     char* tmps = str;
>                     xf86DrvMsg(pScrn->scrnIndex, X_WARNING,
>                         "Mode \"%s\" is not a supported mode for CRT1\n", modename);
>-                    while(*tmps == ' ') tmps++;
>+                    while(*tmps == ' ' || *tmps == ';') tmps++;
>                     /* skip the next mode */
>-  	            if((*tmps == '-') || (*tmps == '+')) {
>+  	            if(*tmps == '-' || *tmps == '+' || *tmps == ',') {
>                        tmps++;
> 		       /* skip spaces */
>-		       while(*tmps == ' ') tmps++;
>+		       while(*tmps == ' ' || *tmps == ';') tmps++;
> 		       /* skip modename */
>-		       while((*tmps != ' ') && (*tmps != '-') && (*tmps != '+') && (*tmps != 0)) tmps++;
>+		       while(*tmps && *tmps != ' ' && *tmps != ';' && *tmps != '-' && *tmps != '+' && *tmps != ',') tmps++;
>   	               myslen = tmps - strmode;
>   	               if(myslen > 255) myslen = 255;
>   	               strncpy(modename,strmode,myslen);
>@@ -474,14 +477,15 @@ RADEONGenerateModeListFromMetaModes(Scrn
>                     xf86DrvMsg(pScrn->scrnIndex, X_WARNING,
>                         "\t(Skipping metamode \"%s\")\n", modename);
>                     mode1 = NULL;
>-		    gotplus = FALSE;
>+		    gotsep = 0;
>                  }
>               }
>               gotdash = FALSE;
>            }
>            strmode = str + 1;
>-           gotdash |= ((*str == '-') || (*str == '+'));
>-  	   gotplus |= (*str == '+');
>+           gotdash |= (*str == '-' || *str == '+' || *str == ',');
>+	   if (*str == '-' || *str == '+' || *str == ',')
>+  	      gotsep = *str;
> 
>            if(*str != 0) break;
> 	   /* Fall through otherwise */
>@@ -489,7 +493,7 @@ RADEONGenerateModeListFromMetaModes(Scrn
>         default:
>            if(!gotdash && mode1) {
>               sr = srel;
>-	      if(gotplus) sr = radeonClone;
>+	      if(gotsep == '+') sr = radeonClone;
>               if(!mode2) {
>                  mode2 = RADEONGetModeFromName(mode1->name, j);
>                  sr = radeonClone;
>@@ -505,7 +509,7 @@ RADEONGenerateModeListFromMetaModes(Scrn
>                  mode1 = NULL;
>                  mode2 = NULL;
>               }
>-	      gotplus = FALSE;
>+	      gotsep = 0;
>            }
>            break;
> 
>Index: programs/Xserver/hw/xfree86/drivers/sis/sis_driver.c
>===================================================================
>RCS file: /cvs/xorg/xc/programs/Xserver/hw/xfree86/drivers/sis/sis_driver.c,v
>retrieving revision 1.58
>diff -u -p -b -r1.58 sis_driver.c
>--- programs/Xserver/hw/xfree86/drivers/sis/sis_driver.c	8 Aug 2005 11:40:36 -0000	1.58
>+++ programs/Xserver/hw/xfree86/drivers/sis/sis_driver.c	10 Aug 2005 18:31:27 -0000
>@@ -1483,8 +1483,8 @@ SiSGenerateModeListFromLargestModes(Scrn
>     return result;
> }
> 
>-/* Generate the merged-fb mode modelist from metamodes
>- * (Code base taken from mga driver)
>+/* Generate the merged-fb mode modelist
>+ * (Taken from mga driver)
>  */
> static DisplayModePtr
> SiSGenerateModeListFromMetaModes(ScrnInfoPtr pScrn, char* str,
>@@ -1496,7 +1496,8 @@ SiSGenerateModeListFromMetaModes(ScrnInf
> #endif
>     char* strmode = str;
>     char modename[256];
>-    Bool gotdash = FALSE, gotplus = FALSE;
>+    Bool gotdash = FALSE;
>+    char gotsep = 0;
>     SiSScrn2Rel sr;
>     DisplayModePtr mode1 = NULL;
>     DisplayModePtr mode2 = NULL;
>@@ -1513,6 +1514,8 @@ SiSGenerateModeListFromMetaModes(ScrnInf
> 	case '-':
> 	case '+':
> 	case ' ':
>+	case ',':
>+	case ';':
> 	   if(strmode != str) {
> 
> 	      myslen = str - strmode;
>@@ -1531,9 +1534,9 @@ SiSGenerateModeListFromMetaModes(ScrnInf
> 		    xf86DrvMsg(pScrn->scrnIndex, X_WARNING,
> 			"Mode \"%s\" is not a supported mode for CRT2\n", modename);
> 		    xf86DrvMsg(pScrn->scrnIndex, X_WARNING,
>-			"\t(Skipping metamode \"%s%s%s\")\n", mode1->name, gotplus ? "+" : "-", modename);
>+                        "\t(Skipping metamode \"%s%c%s\")\n", mode1->name, gotsep, modename);
> 		    mode1 = NULL;
>-		    gotplus = FALSE;
>+		    gotsep = 0;
> 		 }
> 	      } else {
> 		 mode1 = SiSGetModeFromName(modename, i);
>@@ -1541,29 +1544,32 @@ SiSGenerateModeListFromMetaModes(ScrnInf
> 		    char* tmps = str;
> 		    xf86DrvMsg(pScrn->scrnIndex, X_WARNING,
> 			"Mode \"%s\" is not a supported mode for CRT1\n", modename);
>-		    while(*tmps == ' ') tmps++;
>+                    while(*tmps == ' ' || *tmps == ';') tmps++;
> 		    /* skip the next mode */
>-		    if((*tmps == '-') || (*tmps == '+')) {
>+  	            if(*tmps == '-' || *tmps == '+' || *tmps == ',') {
> 		       tmps++;
> 		       /* skip spaces */
>-		       while(*tmps == ' ') tmps++;
>+		       while(*tmps == ' ' || *tmps == ';') tmps++;
> 		       /* skip modename */
>-		       while((*tmps != ' ') && (*tmps != '-') && (*tmps != '+') && (*tmps != 0)) tmps++;
>+		       while(*tmps && *tmps != ' ' && *tmps != ';' && *tmps != '-' && *tmps != '+' && *tmps != ',') tmps++;
> 		       myslen = tmps - strmode;
> 		       if(myslen > 255) myslen = 255;
> 		       strncpy(modename,strmode,myslen);
> 		       modename[myslen] = 0;
> 		       str = tmps - 1;
> 		    }
>+                    xf86DrvMsg(pScrn->scrnIndex, X_WARNING,
>+                        "\t(Skipping metamode \"%s\")\n", modename);
> 		    mode1 = NULL;
>-		    gotplus = FALSE;
>+		    gotsep = 0;
> 		 }
> 	      }
> 	      gotdash = FALSE;
> 	   }
> 	   strmode = str + 1;
>-	   gotdash |= ((*str == '-') || (*str == '+'));
>-	   gotplus |= (*str == '+');
>+           gotdash |= (*str == '-' || *str == '+' || *str == ',');
>+	   if (*str == '-' || *str == '+' || *str == ',')
>+  	      gotsep = *str;
> 
> 	   if(*str != 0) break;
> 	   /* Fall through otherwise */
>@@ -1571,7 +1577,7 @@ SiSGenerateModeListFromMetaModes(ScrnInf
>         default:
> 	   if(!gotdash && mode1) {
> 	      sr = srel;
>-	      if(gotplus) sr = sisClone;
>+	      if(gotsep == '+') sr = sisClone;
> 	      if(!mode2) {
> 	         mode2 = SiSGetModeFromName(mode1->name, j);
> 	         sr = sisClone;
>@@ -1579,13 +1585,15 @@ SiSGenerateModeListFromMetaModes(ScrnInf
> 	      if(!mode2) {
> 		 xf86DrvMsg(pScrn->scrnIndex, X_WARNING,
> 		     "Mode \"%s\" is not a supported mode for CRT2\n", mode1->name);
>+                 xf86DrvMsg(pScrn->scrnIndex, X_WARNING,
>+                     "\t(Skipping metamode \"%s\")\n", modename);
> 		 mode1 = NULL;
> 	      } else {
> 		 result = SiSCopyModeNLink(pScrn, result, mode1, mode2, sr);
> 		 mode1 = NULL;
> 		 mode2 = NULL;
> 	      }
>-	      gotplus = FALSE;
>+	      gotsep = 0;
> 	   }
> 	   break;
>

Actions: View | Diff

Attachments on bug 104069: 45687 | 45809