Attachment 49234 Details for Bug 115837

[patch] Add "buggy_semaphore" option

intel8x0-buggy-semaphore.diff (text/plain), 1.85 KB, created by Takashi Iwai on 2005-09-08 16:18:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Takashi Iwai

Created: 2005-09-08 16:18:58 UTC

Size: 1.85 KB

patch

obsolete

>--- linux/sound/pci/intel8x0.c	7 Sep 2005 12:56:34 -0000	1.207
>+++ linux/sound/pci/intel8x0.c	8 Sep 2005 16:16:22 -0000
>@@ -69,6 +69,7 @@
> static int enable[SNDRV_CARDS] = SNDRV_DEFAULT_ENABLE_PNP;	/* Enable this card */
> static int ac97_clock[SNDRV_CARDS] = {[0 ... (SNDRV_CARDS - 1)] = 0};
> static char *ac97_quirk[SNDRV_CARDS];
>+static int buggy_semaphore[SNDRV_CARDS];
> static int buggy_irq[SNDRV_CARDS];
> static int xbox[SNDRV_CARDS];
> 
>@@ -86,6 +87,8 @@
> MODULE_PARM_DESC(ac97_clock, "AC'97 codec clock (0 = auto-detect).");
> module_param_array(ac97_quirk, charp, NULL, 0444);
> MODULE_PARM_DESC(ac97_quirk, "AC'97 workaround for strange hardware.");
>+module_param_array(buggy_semaphore, bool, NULL, 0444);
>+MODULE_PARM_DESC(buggy_semaphore, "Enable workaround for hardwares with problematic codec semaphores.");
> module_param_array(buggy_irq, bool, NULL, 0444);
> MODULE_PARM_DESC(buggy_irq, "Enable workaround for buggy interrupts on some motherboards.");
> module_param_array(xbox, bool, NULL, 0444);
>@@ -367,6 +370,7 @@
> 	unsigned fix_nocache: 1; 	/* workaround for 440MX */
> 	unsigned buggy_irq: 1;		/* workaround for buggy mobos */
> 	unsigned xbox: 1;		/* workaround for Xbox AC'97 detection */
>+	unsigned buggy_semaphore: 1;	/* workaround for buggy codec semaphore */
> 
> 	int spdif_idx;	/* SPDIF BAR index; *_SPBAR or -1 if use PCMOUT */
> 	unsigned int sdm_saved;	/* SDM reg value */
>@@ -521,6 +525,9 @@
> 	if ((igetdword(chip, ICHREG(GLOB_STA)) & codec) == 0)
> 		return -EIO;
> 
>+	if (chip->buggy_semaphore)
>+		return 0; /* just ignore ... */
>+
> 	/* Anyone holding a semaphore for 1 msec should be shot... */
> 	time = 100;
>       	do {
>@@ -2818,6 +2825,8 @@
> 		chip->buggy_irq = 1;
> 	if (xbox[dev])
> 		chip->xbox = 1;
>+	if (buggy_semaphore[dev])
>+		chip->buggy_semaphore = 1;
> 
> 	if ((err = snd_intel8x0_mixer(chip, ac97_clock[dev], ac97_quirk[dev])) < 0) {
> 		snd_card_free(card);

Actions: View | Diff

Attachments on bug 115837: 49184 | 49217 | 49234 | 49249