Attachment 49252 Details for Bug 113112

[patch] skip NULL _PDC writes

pdc_skip_workaround.patch (text/plain), 1.24 KB, created by Venkatesh Pallipadi on 2005-09-08 17:47:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Venkatesh Pallipadi

Created: 2005-09-08 17:47:47 UTC

Size: 1.24 KB

patch

obsolete

>
>No need to write _PDC with NULL values. We can just skip the write altogether.
>
>Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
>
>
>Index: linux-2.6.12/drivers/acpi/processor_core.c
>===================================================================
>--- linux-2.6.12.orig/drivers/acpi/processor_core.c	2005-09-07 14:42:38.594582576 -0700
>+++ linux-2.6.12/drivers/acpi/processor_core.c	2005-09-08 09:43:20.396847112 -0700
>@@ -258,24 +258,15 @@
> 			   struct acpi_object_list *pdc_in)
> {
> 	acpi_status status = AE_OK;
>-	u32 arg0_buf[3];
>-	union acpi_object arg0 = { ACPI_TYPE_BUFFER };
>-	struct acpi_object_list no_object = { 1, &arg0 };
>-	struct acpi_object_list *pdc;
> 
> 	ACPI_FUNCTION_TRACE("acpi_processor_set_pdc");
> 
>-	arg0.buffer.length = 12;
>-	arg0.buffer.pointer = (u8 *) arg0_buf;
>-	arg0_buf[0] = ACPI_PDC_REVISION_ID;
>-	arg0_buf[1] = 0;
>-	arg0_buf[2] = 0;
>+	if (!pdc_in)
>+		return_VALUE(status);
> 
>-	pdc = (pdc_in) ? pdc_in : &no_object;
>+	status = acpi_evaluate_object(pr->handle, "_PDC", pdc_in, NULL);
> 
>-	status = acpi_evaluate_object(pr->handle, "_PDC", pdc, NULL);
>-
>-	if ((ACPI_FAILURE(status)) && (pdc_in))
>+	if (ACPI_FAILURE(status))
> 		ACPI_DEBUG_PRINT((ACPI_DB_INFO,
> 				  "Error evaluating _PDC, using legacy perf. control...\n"));
>

Actions: View | Diff

Attachments on bug 113112: 49252 | 49858