Bugzilla – Attachment 56577 Details for
Bug 116341
PwManager Crashes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
IDP Log In
|
Forgot Password
[patch]
fix stack corruption
stack-corruption.diff (text/plain), 894 bytes, created by
Dirk Mueller
on 2005-11-07 10:46:12 UTC
(
hide
)
Description:
fix stack corruption
Filename:
MIME Type:
Creator:
Dirk Mueller
Created:
2005-11-07 10:46:12 UTC
Size:
894 bytes
patch
obsolete
>------------------------------------------------------------------------ >r478145 | mbuesch | 2005-11-06 01:47:00 +0100 (Sun, 06 Nov 2005) | 2 lines > >fix stack corruption > >------------------------------------------------------------------------ >Index: pwmanager/pwmdoc.cpp >=================================================================== >--- pwmanager/pwmdoc.cpp (revision 478144) >+++ pwmanager/pwmdoc.cpp (revision 478145) >@@ -314,13 +314,14 @@ > * move tmp file back. See below. > */ > Randomizer rnd; >- char rnd_buf[5]; >+ char rnd_buf[9] = { 0 }; > char c0, c1, c2, c3; > rnd >> c0; > rnd >> c1; > rnd >> c2; > rnd >> c3; >- sprintf(rnd_buf, "%X%X%X%X", c0, c1, c2, c3); >+ sprintf(rnd_buf, "%02x%02x%02x%02x", >+ c0 & 0xFF, c1 & 0xFF, c2 & 0xFF, c3 & 0xFF); > tmpFileMoved = filename + "." + rnd_buf + ".mv"; > if (!copyFile(filename, tmpFileMoved)) > return e_openFile;
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=56577">View the attachment on a separate page</a>.</b>
Actions:
View
|
Diff
Attachments on
bug 116341
:
49602
| 56577