Bugzilla – Attachment 60134 Details for
Bug 135497
perl decode_utf8 function broken?
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
IDP Log In
|
Forgot Password
patch to make convmv work with Perl 5.8.7
convmv.diff (text/x-patch), 740 bytes, created by
Bjoern Jacke
on 2005-12-08 19:33:37 UTC
(
hide
)
Description:
patch to make convmv work with Perl 5.8.7
Filename:
MIME Type:
Creator:
Bjoern Jacke
Created:
2005-12-08 19:33:37 UTC
Size:
740 bytes
patch
obsolete
>--- convmv.old 2005-12-08 21:23:29.000000000 +0100 >+++ convmv 2005-12-08 19:48:52.000000000 +0100 >@@ -506,7 +506,7 @@ > my $oldfile=shift; > my $new=$oldfile; > if ($from_is_utf8) { >- if (! defined(decode_utf8($new))) { >+ if (! defined(utf8::decode($new))) { > print STDERR "this file was not validly encoded in UTF-8: \"". &$from_print($dir.$oldfile) ."\"\n"; > return 0; > } >@@ -575,7 +575,9 @@ > > sub looks_like_utf8() { > my $string = shift; >- if ($string =~ m/[^[:ascii:]]/ and decode_utf8($string)) { >+# this utf8::decode() used to be decode_utf8() but Encode 2.10 in >+# Perl 5.8.7 broke the docs from perluniintro man page :-| >+ if ($string =~ m/[^[:ascii:]]/ and utf8::decode($string)) { > return 1; > } else { > return 0;
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=60134">View the attachment on a separate page</a>.</b>
Actions:
View
Attachments on
bug 135497
: 60134