Attachment 630231 Details for Bug 926169

0001-random-seed-accidental-stack-corruption.patch

0001-random-seed-accidental-stack-corruption.patch (text/plain), 1.21 KB, created by Thomas Blume on 2015-04-07 14:44:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Thomas Blume

Created: 2015-04-07 14:44:26 UTC

Size: 1.21 KB

patch

obsolete

>--- systemd-210.mod/src/random-seed/random-seed.c	2015-02-24 16:23:18.536399553 +0100
>+++ systemd-210/src/random-seed/random-seed.c	2015-04-07 14:04:15.918091153 +0200
>@@ -134,12 +134,13 @@
>                         lseek(seed_fd, 0, SEEK_SET);
> 
>                         if (entropy_count && (size_t) k == buf_size) {
>-                                struct rand_pool_info entropy = {
>+                                struct rand_pool_info entropy_buf[2] = {{
>                                         .entropy_count = entropy_count,
>                                         .buf_size = buf_size,
>-                                };
>-                                entropy.buf[0] = ((__u32*)buf)[0];
>-                                r = ioctl(random_fd, RNDADDENTROPY, &entropy);
>+                                }};
>+                                struct rand_pool_info *entropy = &entropy_buf[0];
>+                                entropy->buf[0] = ((__u32*)buf)[0];
>+                                r = ioctl(random_fd, RNDADDENTROPY, entropy);
>                                 if (r < 0) {
>                                         log_error("Failed to write seed to /dev/urandom: %m");
>                                         r = -errno;

Actions: View

Attachments on bug 926169: 630158 | 630231 | 630992