Attachment 65982 Details for Bug 145459

[patch] Only init online CPUs

cpu-online-stuff (text/plain), 1.15 KB, created by Jens Axboe on 2006-02-01 08:56:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jens Axboe

Created: 2006-02-01 08:56:06 UTC

Size: 1.15 KB

patch

obsolete

>diff --git a/block/ll_rw_blk.c b/block/ll_rw_blk.c
>index d38b4af..58265e3 100644
>--- a/block/ll_rw_blk.c
>+++ b/block/ll_rw_blk.c
>@@ -3316,6 +3316,12 @@ static int blk_cpu_notify(struct notifie
> 				 &__get_cpu_var(blk_cpu_done));
> 		raise_softirq_irqoff(BLOCK_SOFTIRQ);
> 		local_irq_enable();
>+	} else if (action == CPU_ONLINE) {
>+		int cpu = (unsigned long) hcpu;
>+
>+		local_irq_disable();
>+		INIT_LIST_HEAD(&per_cpu(blk_cpu_done, cpu));
>+		local_irq_enable();
> 	}
> 
> 	return NOTIFY_OK;
>@@ -3451,7 +3457,7 @@ int __init blk_dev_init(void)
> 	iocontext_cachep = kmem_cache_create("blkdev_ioc",
> 			sizeof(struct io_context), 0, SLAB_PANIC, NULL, NULL);
> 
>-	for (i = 0; i < NR_CPUS; i++)
>+	for_each_online_cpu(i)
> 		INIT_LIST_HEAD(&per_cpu(blk_cpu_done, i));
> 
> 	open_softirq(BLOCK_SOFTIRQ, blk_done_softirq, NULL);
>diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c
>index 245ca99..10e0ac1 100644
>--- a/drivers/scsi/scsi.c
>+++ b/drivers/scsi/scsi.c
>@@ -1245,7 +1245,7 @@ static int __init init_scsi(void)
> 	if (error)
> 		goto cleanup_sysctl;
> 
>-	for (i = 0; i < NR_CPUS; i++)
>+	for_each_online_cpu(i)
> 		INIT_LIST_HEAD(&per_cpu(scsi_done_q, i));
> 
> 	devfs_mk_dir("scsi");

Actions: View | Diff

Attachments on bug 145459: 65982 | 66026 | 66027