Attachment 664559 Details for Bug 964548

[patch] Possible patch

0001-greeter-Dont-quit-when-last-window-closes.patch (text/plain), 1.51 KB, created by Martin Gräßlin on 2016-02-05 09:50:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Gräßlin

Created: 2016-02-05 09:50:35 UTC

Size: 1.51 KB

patch

obsolete

>From 03d4dc99228193896ce145c6222fbccab79a92a5 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Martin=20Gr=C3=A4=C3=9Flin?= <mgraesslin@kde.org>
>Date: Fri, 5 Feb 2016 10:30:19 +0100
>Subject: [PATCH] [greeter] Dont quit when last window closes
>
>Qt allows to have no screens. If all XRandR screens are disconnected
>there are also no QScreens. This is from an X11 perspective wrong, but
>we have to deal with it. No QScreens means that all views are destroyed
>and no new ones are created. Thus all windows close and the greeter
>exited successfully which in turn unlocked the screen.
>
>This change ensures that the greeter doesn't exit when all windows close.
>
>Funnily this was not a problem with the well known issue of Qt
>crashing when all screens are disconnected. The lock screen handles
>crashes gracefully and just restarts or more likely Qt also crashes
>the application using KSld and thus taking down the complete session.
>---
> greeter/main.cpp | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/greeter/main.cpp b/greeter/main.cpp
>index e4e679e..5625d36 100644
>--- a/greeter/main.cpp
>+++ b/greeter/main.cpp
>@@ -59,6 +59,7 @@ int main(int argc, char* argv[])
>         qputenv("QT_IM_MODULE", QByteArrayLiteral("compose"));
>     }
>     ScreenLocker::UnlockApp app(argc, argv);
>+    app.setQuitOnLastWindowClosed(false);
>     QCoreApplication::setApplicationName(QStringLiteral("kscreenlocker_greet"));
>     QCoreApplication::setApplicationVersion(QStringLiteral("0.1"));
>     QCoreApplication::setOrganizationDomain(QStringLiteral("kde.org"));
>-- 
>2.7.0
>

Actions: View | Diff

Attachments on bug 964548: 664062 | 664478 | 664559 | 664611 | 665550 | 666317