Attachment 66829 Details for Bug 148693

[patch] fc-app-dir-fix.diff

fc-app-dir-fix.diff (text/plain), 3.23 KB, created by Mike Fabian on 2006-02-07 16:46:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mike Fabian

Created: 2006-02-07 16:46:53 UTC

Size: 3.23 KB

patch

obsolete

>--- src/fccfg.c-dist	2006-02-07 16:11:14.000000000 +0100
>+++ src/fccfg.c	2006-02-07 16:36:04.000000000 +0100
>@@ -418,11 +418,6 @@ FcBool
> FcConfigAddFontDir (FcConfig	    *config,
> 		    const FcChar8   *d)
> {
>-#if 1 /* to be sure */
>-    /* already exists? */
>-    if (FcConfigLookupAllDirs(config, d))
>-	return FcTrue;
>-#endif
>     return FcStrSetAddFilename (config->fontDirs, d);
> }
> 
>@@ -1879,9 +1874,10 @@ FcConfigAppFontAddFile (FcConfig    *con
>     return FcTrue;
> }
> 
>-FcBool
>-FcConfigAppFontAddDir (FcConfig	    *config,
>-		       const FcChar8   *dir)
>+static FcBool
>+FcConfigAppFontAddDirWithCheck (FcConfig	    *config,
>+				const FcChar8   *dir,
>+				FcStrSet *processed_dirs)
> {
>     FcFontSet	*set;
>     FcStrSet	*subdirs;
>@@ -1915,11 +1911,17 @@ FcConfigAppFontAddDir (FcConfig	    *con
> 	FcStrSetDestroy (subdirs);
> 	return FcFalse;
>     }
>+    FcStrSetAdd (processed_dirs, dir);
>     if ((sublist = FcStrListCreate (subdirs)))
>     {
> 	while ((subdir = FcStrListNext (sublist)))
> 	{
>-	    FcConfigAppFontAddDir (config, subdir);
>+	    FcChar8 *name;
>+	    name = FcConfigNormalizeFontDir (config, subdir);
>+	    if (! name)
>+		name = subdir;
>+	    if (! FcStrSetMember (processed_dirs, name))
>+		FcConfigAppFontAddDirWithCheck (config, name, processed_dirs);
> 	}
> 	FcStrListDone (sublist);
>     }
>@@ -1927,6 +1929,23 @@ FcConfigAppFontAddDir (FcConfig	    *con
>     return FcTrue;
> }
> 
>+FcBool
>+FcConfigAppFontAddDir (FcConfig	    *config,
>+		       const FcChar8   *dir)
>+{
>+    FcStrSet *processed_dirs;
>+    FcBool res;
>+
>+    processed_dirs = FcStrSetCreate ();
>+    if (! processed_dirs)
>+	return FcFalse;
>+
>+    res = FcConfigAppFontAddDirWithCheck (config, dir, processed_dirs);
>+    FcStrSetDestroy (processed_dirs);
>+
>+    return res;
>+}
>+
> void
> FcConfigAppFontClear (FcConfig	    *config)
> {
>--- src/fccache.c-dist	2006-02-06 17:20:01.000000000 +0100
>+++ src/fccache.c	2006-02-07 16:37:21.000000000 +0100
>@@ -879,12 +879,11 @@ FcCacheReadDirs (FcConfig * config, FcGl
> 	    continue;
> 
> 	/* Skip this directory if already scanned */
>-	name = FcConfigNormalizeFontDir (config, dir);
>-	if (name) {
>-	    if (FcStrSetMember (processed_dirs, dir))
>-		continue;
>-	    FcStrSetAdd (processed_dirs, dir);
>-	}
>+	dir = FcConfigNormalizeFontDir (config, dir);
>+	if (! dir)
>+	    continue;
>+	if (! FcStrSetAdd (processed_dirs, dir))
>+	    continue;
> 
> 	subdirs = FcStrSetCreate ();
> 	if (!subdirs)
>@@ -926,7 +925,7 @@ FcCacheReadDirs (FcConfig * config, FcGl
> 	if (FcDirCacheValid (dir) && FcDirCacheRead (set, subdirs, dir, config))
> 	{
> 	    /* if an old entry is found in the global cache, disable it */
>-	    if ((d = FcGlobalCacheDirFind (cache, (const char *)name)) != NULL) {
>+	    if ((d = FcGlobalCacheDirFind (cache, (const char *)dir)) != NULL) {
> 		d->state = FcGCDirDisabled;
> 		/* save the updated config later without this entry */
> 		cache->updated = FcTrue;
>--- src/fcdir.c-dist	2006-02-06 17:20:43.000000000 +0100
>+++ src/fcdir.c	2006-02-07 16:17:11.000000000 +0100
>@@ -129,11 +129,7 @@ FcDirScanConfig (FcFontSet	*set,
> 	return FcTrue;
> 
>     if (config)
>-	dir = FcConfigNormalizeFontDir (config, dir);
>-
>-    /* refuse to scan a directory that can't be normalized. */
>-    if (!dir)
>-	return FcFalse;
>+        FcConfigAddFontDir (config, dir);
> 
>     if (!force)
>     {

Actions: View | Diff

Attachments on bug 148693: 66754 | 66808 | 66829 | 66830 | 66842 | 67657