Attachment 66861 Details for Bug 148683

[patch] 148683-nonfix.patch

148683-nonfix.patch (text/plain), 1.37 KB, created by Martin Vidner on 2006-02-07 18:43:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Vidner

Created: 2006-02-07 18:43:56 UTC

Size: 1.37 KB

patch

obsolete

>Index: library/desktop/src/menu.ycp
>===================================================================
>--- library/desktop/src/menu.ycp	(revision 27701)
>+++ library/desktop/src/menu.ycp	(working copy)
>@@ -80,8 +80,8 @@
>  */
> define boolean Launch(string modul) {
>     string function = Modules[modul, "X-SuSE-YaST-Call"]:"";
>-    list arguments = splitstring(Modules[modul, "X-SuSE-YaST-Argument"]:"", " ");
>-    y2debug("Calling: %1 (%2)", function, arguments);
>+    string argument = Modules[modul, "X-SuSE-YaST-Argument"]:"";
>+    y2debug("Calling: %1 (%2)", function, argument);
> 
>     if(function != "") {
> 	list<string> packages = [];
>@@ -95,8 +95,16 @@
> 		return substring (p, 0, 5) == "yast2";
> 	    }));
> 	}
>-	any ret = WFM::CallFunction (function, arguments);
>-	y2debug("WFM::CallFunction (%1, %2) returns: %3", function, arguments, ret);
>+
>+	// #148683
>+	// A separate process instead of WFM::CallFunction is cleaner.
>+	// yast2 would run qt if we ran it from ncurses xterm
>+	// OTOH yast will not run xterm if menu.ycp is run manually with qt.
>+	// But they're not supposed to do that anyway.
>+	string cmd = sformat ("/sbin/yast %1 %2 >&2", function, argument);
>+	any ret = SCR::Execute (.target.bash, cmd);
>+	y2milestone ("Got %1 from %2", ret, cmd);
>+
> 	// online_update always returns 0, so the ret value checking
> 	//  makes no sense
> 	if (function == "online_update"/* && ret != `abort*/)

Actions: View | Diff

Attachments on bug 148683: 66861 | 108513 | 108514 | 108515