Attachment 759816 Details for Bug 1080578

[patch] Let setProgramBinary bail when GL_LINK_STATUS indicates a loading error

setProgramBinary-bail-on-load-failure.diff (text/plain), 1005 bytes, created by Max Staudt on 2018-02-12 13:59:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Max Staudt

Created: 2018-02-12 13:59:11 UTC

Size: 1005 bytes

patch

obsolete

>diff --git a/src/gui/opengl/qopenglprogrambinarycache.cpp b/src/gui/opengl/qopenglprogrambinarycache.cpp
>index 06373e1113..59cc0c29ab 100644
>--- a/src/gui/opengl/qopenglprogrambinarycache.cpp
>+++ b/src/gui/opengl/qopenglprogrambinarycache.cpp
>@@ -162,6 +162,16 @@ bool QOpenGLProgramBinaryCache::setProgramBinary(uint programId, uint blobFormat
>     while (funcs->glGetError() != GL_NO_ERROR) { }
>     funcs->glProgramBinary(programId, blobFormat, p, blobSize);
>     int err = funcs->glGetError();
>+
>+    GLint value;
>+    value = 0;
>+    funcs->glGetProgramiv(program, GL_LINK_STATUS, &value);
>+    if (value != GL_TRUE) {
>+        qCDebug(DBG_SHADER_CACHE, "Program binary failed to load for program %u, size %d, format 0x%x, err = 0x%x",
>+                programId, blobSize, blobFormat, err);
>+        return false;
>+    }
>+
>     qCDebug(DBG_SHADER_CACHE, "Program binary set for program %u, size %d, format 0x%x, err = 0x%x",
>             programId, blobSize, blobFormat, err);
>     return err == 0;

Actions: View | Diff

Attachments on bug 1080578: 759816