Attachment 871410 Details for Bug 1215102

shim commit CVE-2023-40550 from keybase

out-of-bound-40550.txt (text/plain), 1.27 KB, created by Tseng on 2023-12-18 06:49:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tseng

Created: 2023-12-18 06:49:09 UTC

Size: 1.27 KB

patch

obsolete

>commit 7e5c94dcf1693cec2a653a95e738333187170b33 (HEAD -> main, tag: 15.8-rc1, origin/main)
>Author: Peter Jones <pjones@redhat.com>
>Date:   Tue Sep 5 16:25:05 2023 -0400
>
>    Print errors when setting/clearing memory attrs
>    
>    When working on issues with the memory attributes API, shim does not
>    currently display any errors which are returned from the API itself.
>    
>    This adds those error messages.
>    
>    Resolves #575
>    
>    Signed-off-by: Peter Jones <pjones@redhat.com>
>
>diff --git a/pe.c b/pe.c
>index b3a9d46..3305601 100644
>--- a/pe.c
>+++ b/pe.c
>@@ -498,10 +498,20 @@ update_mem_attrs(uintptr_t addr, uint64_t size,
>        uefi_clear_attrs = shim_mem_attrs_to_uefi_mem_attrs (clear_attrs);
>        dprint("translating clear_attrs from 0x%lx to 0x%lx\n", clear_attrs, uefi_clear_attrs);
>        efi_status = EFI_SUCCESS;
>-       if (uefi_set_attrs)
>+       if (uefi_set_attrs) {
>                efi_status = proto->SetMemoryAttributes(proto, physaddr, size, uefi_set_attrs);
>-       if (!EFI_ERROR(efi_status) && uefi_clear_attrs)
>+               if (EFI_ERROR(efi_status)) {
>+                       dprint(L"Failed to set memory attrs:0x%0x physaddr:0x%llx size:0x%0lx status:%r\n",
>+                               uefi_set_attrs, physaddr, size, efi_status);
>lines 1-30

Actions: View

Attachments on bug 1215102: 871410 | 871509 | 871512