Attachment 876289 Details for Bug 1228269

[patch] Workaround for noise at shutdown

0001-ALSA-hda-generic-Add-a-helper-to-mute-speakers-at-su.patch (text/plain), 3.32 KB, created by Takashi Iwai on 2024-07-26 11:31:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Takashi Iwai

Created: 2024-07-26 11:31:37 UTC

Size: 3.32 KB

patch

obsolete

>From c9849b032bcc555f96c91e5ae8ff1948ad00b8c0 Mon Sep 17 00:00:00 2001
>From: Takashi Iwai <tiwai@suse.de>
>Date: Fri, 26 Jul 2024 13:03:02 +0200
>Subject: [PATCH] ALSA: hda/generic: Add a helper to mute speakers at
> suspend/shutdown
>Patch-mainline: Not yet, testing
>References: bsc#1228269
>
>Some devices indicate click noises at suspend or shutdown when the
>speakers are unmuted.  This patch adds a helper,
>snd_hda_gen_shutup_speakers(), to work around it.  The new function is
>supposed to be called at suspend or shutdown by the codec driver, and
>it mutes the speakers.
>
>The mute status isn't cached, hence the original mute state will be
>restored at resume again.
>
>Signed-off-by: Takashi Iwai <tiwai@suse.de>
>
>---
> sound/pci/hda/hda_generic.c | 54 +++++++++++++++++++++++++++++++++++++
> sound/pci/hda/hda_generic.h |  1 +
> 2 files changed, 55 insertions(+)
>
>diff --git a/sound/pci/hda/hda_generic.c b/sound/pci/hda/hda_generic.c
>index f64d9dc197a3..13cddee1b5d9 100644
>--- a/sound/pci/hda/hda_generic.c
>+++ b/sound/pci/hda/hda_generic.c
>@@ -4955,6 +4955,60 @@ void snd_hda_gen_stream_pm(struct hda_codec *codec, hda_nid_t nid, bool on)
> }
> EXPORT_SYMBOL_GPL(snd_hda_gen_stream_pm);
> 
>+/**
>+ * snd_hda_gen_shutup_speakers - Forcibly mute the speaker outputs
>+ * @codec: the HDA codec
>+ *
>+ * Forcibly mute the speaker outputs, to be called at suspend or shutdown.
>+ *
>+ * The mute state done by this function isn't cached, hence the original state
>+ * will be restored at resume.
>+ */
>+void snd_hda_gen_shutup_speakers(struct hda_codec *codec)
>+{
>+	struct hda_gen_spec *spec = codec->spec;
>+	const int *paths;
>+	const struct nid_path *path;
>+	int i, p, num_paths;
>+	hda_nid_t nid;
>+
>+	/* if already powered off, do nothing */
>+	if (!snd_hdac_is_power_on(&codec->core))
>+		return;
>+
>+	if (spec->autocfg.line_out_type == AUTO_PIN_SPEAKER_OUT) {
>+		paths = spec->out_paths;
>+		num_paths = spec->autocfg.line_outs;
>+	} else {
>+		paths = spec->speaker_paths;
>+		num_paths = spec->autocfg.speaker_outs;
>+	}
>+
>+	for (i = 0; i < num_paths; i++) {
>+		path = snd_hda_get_path_from_idx(codec, paths[i]);
>+		if (!path)
>+			continue;
>+		for (p = 0; p < path->depth; p++) {
>+			nid = path->path[p];
>+			if (!nid)
>+				break;
>+			if (!nid_has_mute(codec, nid, HDA_OUTPUT))
>+				continue; /* no mute, skip */
>+			if (snd_hda_codec_amp_read(codec, nid, 0, HDA_OUTPUT, 0) &
>+			    snd_hda_codec_amp_read(codec, nid, 1, HDA_OUTPUT, 0) &
>+			    HDA_AMP_MUTE)
>+				continue; /* both channels already muted, skip */
>+			/* direct amp update without caching */
>+			snd_hda_codec_write(codec, nid, 0,
>+					    AC_VERB_SET_AMP_GAIN_MUTE,
>+					    AC_AMP_SET_OUTPUT |
>+					    AC_AMP_SET_LEFT | AC_AMP_SET_RIGHT |
>+					    HDA_AMP_MUTE);
>+		}
>+	}
>+}
>+EXPORT_SYMBOL_GPL(snd_hda_gen_shutup_speakers);
>+
> /**
>  * snd_hda_gen_parse_auto_config - Parse the given BIOS configuration and
>  * set up the hda_gen_spec
>diff --git a/sound/pci/hda/hda_generic.h b/sound/pci/hda/hda_generic.h
>index 8f5ecf740c49..dcefec1a7997 100644
>--- a/sound/pci/hda/hda_generic.h
>+++ b/sound/pci/hda/hda_generic.h
>@@ -353,5 +353,6 @@ int snd_hda_gen_add_mute_led_cdev(struct hda_codec *codec,
> int snd_hda_gen_add_micmute_led_cdev(struct hda_codec *codec,
> 				     int (*callback)(struct led_classdev *,
> 						     enum led_brightness));
>+void snd_hda_gen_shutup_speakers(struct hda_codec *codec);
> 
> #endif /* __SOUND_HDA_GENERIC_H */
>-- 
>2.43.0
>

Actions: View | Diff

Attachments on bug 1228269: 876227 | 876228 | 876229 | 876230 | 876231 | 876232 | 876233 | 876239 | 876240 | 876241 | 876269 | 876289