Bug 100469

Summary: fb patch for repeating pictures bug, required for better cairo, OOo cairo canvas performance
Product: [openSUSE] SUSE LINUX 10.0 Reporter: Egbert Eich <eich>
Component: X.OrgAssignee: E-mail List <gnome-bugs>
Status: RESOLVED INVALID QA Contact: Stefan Dirsch <sndirsch>
Severity: Normal    
Priority: P5 - None CC: eich, gnome-bugs, ro
Version: Preview 3   
Target Milestone: ---   
Hardware: Other   
OS: All   
URL: https://bugs.freedesktop.org/show_bug.cgi?id=3566
Whiteboard:
Found By: Other Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: cairo patch

Description Egbert Eich 2005-08-03 10:02:32 UTC
Please add patch in https://bugs.freedesktop.org/show_bug.cgi?id=3566 to our
cvs. This one will improve the RENDER performance for Cairo.
Comment 1 Radek Doulik 2005-08-03 15:27:19 UTC
I am attaching patch for cairo package. This patch will be valid once suse xorg
server will have patch in https://bugs.freedesktop.org/show_bug.cgi?id=3566 applied.

There might be better way of identifing that. Right now it changes the test for
buggy xorg server, assuming that xorg 6.8.2 is patched. Ideally we might
indicate it in version or vendor string, but it doesn't seem very clean to me.
Any better idea, or is it OK that way?
Comment 2 Radek Doulik 2005-08-03 15:28:37 UTC
Created attachment 44659 [details]
cairo patch
Comment 3 Stanislav Brabec 2005-08-03 15:35:03 UTC
Cairo patch is prepared for submission. Please confirm, that patch for Xorg will
be accepted for SuSE Linux 10.0.
Comment 4 Stanislav Brabec 2005-08-04 13:10:21 UTC
Stefan Dirsch is on vacation. Can you apply the patch for beta1? Or can I do it?
Comment 5 Ruediger Oertel 2005-08-04 13:12:40 UTC
patch added, xorg-x11 submitted to stable 
Comment 6 Stanislav Brabec 2005-08-04 13:44:27 UTC
Cairo patch submitted. Closing.
Comment 7 Radek Doulik 2005-09-01 09:33:07 UTC
I have bugreports for b3/b4 about image scaling in OOo cairo canvas. It works
better, but not completely right. So it will be better to remove at least the
cairo patch so that cairo fallbacks to the workarounds again.
Comment 8 Stefan Dirsch 2005-09-01 10:51:58 UTC
cairo patch --> cairo maintainer
Comment 9 JP Rosevear 2005-09-04 21:48:57 UTC
egbert, any comment?
Comment 10 Egbert Eich 2005-09-05 13:41:44 UTC
What would you like me to comment on? I could comment on the patch for X.Org -
if I could see it. However the attachment to the ticket
https://bugs.freedesktop.org/show_bug.cgi?id=3566 now point to Matthias Hopf's
gpg key instead of the patch.
However the patch to fb has been reviewed by Keith - the author of the code -
and applied to CVS. Therefore I guess it's OK.
Comment 11 JP Rosevear 2005-09-20 14:32:27 UTC
#10 Are we shipping this patch yet?

#2 Radek does this patch still valid for cairo 1.0.0?
Comment 12 Stefan Dirsch 2005-09-20 14:54:25 UTC
> #10 Are we shipping this patch yet?  
Yes, this patch is applied for 10.0.  
  
--> /work/SRC/all/BASE/xorg-x11/p_bug100469.diff 
Comment 13 Radek Doulik 2005-10-03 06:19:06 UTC
I think the Xorg patch doesn't fix the problem completely (see my previous
comment), so I would not recommend patching cairo anymore.
Comment 14 JP Rosevear 2006-01-24 21:26:00 UTC
Marking as invalid as per last comment.
Comment 15 Stanislav Brabec 2006-01-25 10:54:39 UTC
OK. In this case we need to remove the patch. Submitted for STABLE:

Wed Jan 25 11:50:29 CET 2006 - sbrabec@suse.cz

- Removed Xlib version fb repeating picture bug check (#100469).