Bug 1042063

Summary:	Dolphin always crashes when it is closed
Product:	[openSUSE] openSUSE Distribution	Reporter:	Roman Bysh <rb03884>
Component:	KDE Applications	Assignee:	Antonio Larrosa <alarrosa>
Status:	RESOLVED FIXED	QA Contact:	E-mail List <qa-bugs>
Severity:	Critical
Priority:	P5 - None	CC:	cornelis, fvogt, rb03884
Version:	Leap 42.3
Target Milestone:	Leap 42.3
Hardware:	x86-64
OS:	openSUSE 42.2
Whiteboard:
Found By:	Community User	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---

Description Roman Bysh 2017-05-31 20:52:31 UTC

User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0
Build Identifier: 

Every time I start and close Dolphin it crashes with a segmentation fault.
Selecting File->Quit and CTRL+Q causes Dolphin to crash 100% of the time.

I have also submitted a bug report upstream. 

https://bugs.kde.org/show_bug.cgi?id=380402

Reproducible: Always

Steps to Reproduce:
1. Click on the Dolphin icon from the menu
2. Click on the "Close" button
3. Dolphin crashes
Actual Results:  
Dolphin crashes with segmentation fault.

Expected Results:  
Dolphin quits.

Comment 1 Fabian Vogt 2017-06-01 07:13:44 UTC

Meh, that looks like the global menu's fault.
Does it work fine when the global menu is disabled?

Comment 2 Fabian Vogt 2017-06-01 08:31:59 UTC

Confirmed the issue, likely due to missing 5ca9631d3a0717afb066471ed5eb3b3ed9a9c08a ("dbusmenu: Don’t leave dangling pointers when menus are destroyed"). A test package is building.

Reassigning to SLE Qt maintainer.

Comment 3 Fabian Vogt 2017-06-01 14:45:42 UTC

(In reply to Fabian Vogt from comment #2)
> Confirmed the issue, likely due to missing
> 5ca9631d3a0717afb066471ed5eb3b3ed9a9c08a ("dbusmenu: Don’t leave dangling
> pointers when menus are destroyed"). A test package is building.
> 
> Reassigning to SLE Qt maintainer.

Package built, might not be published yet: http://download.opensuse.org/repositories/home:/favogt:/branches:/openSUSE:/Leap:/42.3/standard/

Please verify that it fixes the issue.

It took a bit longer as plasma5-integration links the lib statically as well and so it had to be rebuild with the right libqt5-qtbase. That was a PITA to find out...

Also please do not report bugs related to the global menu upstream if they aren't reproducable on the latest supported release, as those are likely downstream issues.

Comment 5 Cor Blom 2017-06-01 19:46:52 UTC

*** Bug 1039818 has been marked as a duplicate of this bug. ***

Comment 6 Cor Blom 2017-06-02 08:07:58 UTC

As said in bug #1039818 the fix proposed here solves the crashes with lyx and smplayer.

Comment 7 Roman Bysh 2017-06-03 19:13:07 UTC

(In reply to Fabian Vogt from comment #3)
> (In reply to Fabian Vogt from comment #2)
> > Confirmed the issue, likely due to missing
> > 5ca9631d3a0717afb066471ed5eb3b3ed9a9c08a ("dbusmenu: Don’t leave dangling
> > pointers when menus are destroyed"). A test package is building.
> > 
> > Reassigning to SLE Qt maintainer.
> 
> Package built, might not be published yet:
> http://download.opensuse.org/repositories/home:/favogt:/branches:/openSUSE:/
> Leap:/42.3/standard/
> 
> Please verify that it fixes the issue.
> 
> It took a bit longer as plasma5-integration links the lib statically as well
> and so it had to be rebuild with the right libqt5-qtbase. That was a PITA to
> find out...
> 
> Also please do not report bugs related to the global menu upstream if they
> aren't reproducable on the latest supported release, as those are likely
> downstream issues.

Okay. No upstream. I wanted to let you know that your patch fixed it.
Dolphin no longer crashes and kate stopped crashing.

Comment 8 Max Lin 2017-06-06 03:44:29 UTC

Seems Antonio did that already, reassign to Antonio then, thanks.

Comment 9 Antonio Larrosa 2017-06-07 07:43:15 UTC

https://build.suse.de/request/show/133532 was submitted 6 days ago. I checked it's already in openSUSE:Leap:42.3