Bug 104670

Summary: ide_cs writes wrong sysfs device link
Product: [openSUSE] SUSE LINUX 10.0 Reporter: Christian Zoz <zoz>
Component: KernelAssignee: Hannes Reinecke <hare>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None CC: hare
Version: Beta 1   
Target Milestone: ---   
Hardware: Other   
OS: All   
Whiteboard:
Found By: Other Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Bug Depends on:    
Bug Blocks: 104675    
Attachments: ide-cs-correct-device-link

Description Christian Zoz 2005-08-15 12:56:18 UTC
pci ide devices have a device link in bus/ide that points to devices/pci/...
With ide_cs this link points to devices/ide/... and not to
devices/pci/....<pcmcia_bridge>/<pcmcia_device>

Can this be changed?

Note: Up to now we fetched that info from /var/lib/pcmcia/stab, but since we
don't have cardmgr any longer, this file does not exist anymore.
Comment 1 Greg Kroah-Hartman 2005-08-16 07:55:26 UTC
I do not have any ide_cs devices, so I can not make this change (well, can't
test it at least.)  Try asking upstream.
Comment 2 Hannes Reinecke 2005-08-16 08:17:51 UTC
Greg, you could have asked first.
Comment 3 Hannes Reinecke 2005-08-17 12:07:56 UTC
Created attachment 46282 [details]
ide-cs-correct-device-link

Patch to add the correct device link for ide-cs.
Comment 4 Hannes Reinecke 2005-08-17 12:08:15 UTC
Christian, can you test the above patch?
Comment 5 Hannes Reinecke 2005-08-17 14:12:50 UTC
Jens, can this patch go in?
Comment 6 Kay Sievers 2005-08-17 15:32:47 UTC
patch works nice for me:
  UDEV  [1124292378] add@/devices/pci0000:00/0000:00:1e.0/0000:02:00.0/0.0
  UDEV  [1124292378] add@/devices/pci0000:00/0000:00:1e.0/0000:02:00.0/0.0/ide2/2.0
  UDEV  [1124292378] add@/block/hde
Comment 7 Jens Axboe 2005-08-17 16:55:00 UTC
Yes, looks good! Ok to commit from my pov.
Comment 8 Hannes Reinecke 2005-08-26 10:13:52 UTC
Patch added to kernel CVS, is part of Beta3.