Bug 1089829

Summary: SLED15: Yast-Boot Loader: Installing the package trustedgrub2 get an error
Product: [SUSE Linux Enterprise Desktop] Beta SUSE Linux Enterprise Desktop 15 Reporter: Rose Tian <roserongxian.tian>
Component: YaST2 Assignee: David Diaz <dgonzalez>
Status: RESOLVED FIXED QA Contact: Jiri Srain <jsrain>
Severity: Normal    
Priority: P2 - High CC: brian.odwyer, dgonzalez, dongyan.liu, jiangong.li, jreidinger, lslezak, maint-coord, mschnitzer, roserongxian.tian
Version: RC 2Keywords: Functionality
Target Milestone: ---   
Hardware: x86-64   
OS: SLED 15   
URL: https://trello.com/c/z14OhJZC
Whiteboard:
Found By: i18n Test Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: SLED15_BootLoader_grub2.jpg
Added the log file: y2log-lNOhVp.tar.xz

Description Rose Tian 2018-04-17 09:50:32 UTC
Created attachment 767382 [details]
SLED15_BootLoader_grub2.jpg

Test Environment:
Build: SLE-15-Installer-DVD-x86_64-Build563.1-Media1_RC3
       SLE-15-Packages-x86_64-Build563.1-Media1_RC3

Steps:
1. Login SLED15;
2. Go to Yast and Open 'Boot Loader';
3. On'Boot Code Options'tab page,tick 'Enable trusted Boot Support',then click OK;
4. On the pop up dialog click 'Continue';
5. Prompt message about installing two trustedgrub2 packages,click 'Install';

Actual results:
Get the Error,please check the attached picture:SLED15_BootLoader_grub2.jpg
Comment 1 Steffen Winterfeldt 2018-04-17 11:40:13 UTC
Please attach yast logs.

To collect log files run 'save_y2logs' and attach the log file archive this
command creates.

If you're still unsure what to do, please have a look at

https://en.opensuse.org/openSUSE:Report_a_YaST_bug#logfiles
Comment 2 Rose Tian 2018-04-18 02:35:49 UTC
Created attachment 767490 [details]
Added the log file: y2log-lNOhVp.tar.xz
Comment 3 Steffen Winterfeldt 2018-04-18 09:01:55 UTC
Thanks!

Apparently the trudtedgrub2 package installation failed but yast didn't complain.

Josef?
Comment 4 Josef Reidinger 2018-04-18 11:48:33 UTC
Lada - bootloader use `Yast::PackageSystem.InstallAll(packages)` . Is it correct call and should I check also return value?
Comment 5 Ladislav Slezák 2018-04-19 07:05:16 UTC
Yes, it is correct. Just keep in mind that this call can used only in installed system.

You really should check the return value (returns `true` on success) because it displays a popup and user can can press [Cancel] and not confirm the package installation. In that case it returns `false` as well.
Comment 6 Josef Reidinger 2018-04-19 07:08:13 UTC
yes, so check of return value is missing. Please trelloize, thanks.
Comment 7 David Diaz 2018-09-04 11:08:18 UTC
There is already a fix prepared to be included in SLE-15-SP1, which avoid to continue if the installation of required packages is rejected.

PR: https://github.com/yast/yast-bootloader/pull/536/

However, we want to know if those changes should be also included in the maintenance update.

Thank you.
Comment 9 David Diaz 2018-09-26 14:14:25 UTC
Finally, we decided to go ahead including the fix in the SLE-15 SP1 for now. If it were necessary, we could backport it in the future.

SR: https://build.suse.de/request/show/172930

Thank you.
Comment 10 David Diaz 2018-09-26 14:52:11 UTC
Backport for SLE-15 created

* PR: https://github.com/yast/yast-bootloader/pull/538
* MR: https://build.suse.de/request/show/172937
Comment 11 Swamp Workflow Management 2018-10-25 16:15:17 UTC
SUSE-RU-2018:3442-1: An update that has three recommended fixes can now be installed.

Category: recommended (moderate)
Bug References: 1053559,1089829,1094031
CVE References: 
Sources used:
SUSE Linux Enterprise Module for Basesystem 15 (src):    rubygem-cfa_grub2-1.0.1-3.3.2, yast2-bootloader-4.0.39-3.5.1
Comment 12 Swamp Workflow Management 2018-10-26 22:26:17 UTC
openSUSE-RU-2018:3521-1: An update that has three recommended fixes can now be installed.

Category: recommended (moderate)
Bug References: 1053559,1089829,1094031
CVE References: 
Sources used:
openSUSE Leap 15.0 (src):    rubygem-cfa_grub2-1.0.1-lp150.2.3.1, yast2-bootloader-4.0.39-lp150.2.8.1