Bug 1096960

Summary: YaST crashes on upgrade from 42.3 to 15.0
Product: [openSUSE] openSUSE Distribution Reporter: Carlos Robinson <carlos.e.r>
Component: Upgrade ProblemsAssignee: E-mail List <yast2-maintainers>
Status: RESOLVED FIXED QA Contact: Jiri Srain <jsrain>
Severity: Normal    
Priority: P5 - None CC: ancor, drankinatty, jlopez, kanderssen, mrmazda, rbrown, suseforum, yast2-maintainers
Version: Leap 42.3   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: Error message window
Second message
Third message
save yast logs

Description Carlos Robinson 2018-06-11 13:01:21 UTC
Created attachment 773447 [details]
Error message window

YaST crashes on upgrade from 42.3 to 15.0
See photos for exact error message.
Logs attached later.
Comment 1 Carlos Robinson 2018-06-11 13:01:59 UTC
Created attachment 773448 [details]
Second message
Comment 2 Carlos Robinson 2018-06-11 13:03:02 UTC
Created attachment 773450 [details]
Third message

I get this message when I click on retry. YaST does not progress or respond from this point.
Comment 3 Carlos Robinson 2018-06-11 13:06:23 UTC
Created attachment 773451 [details]
save yast logs
Comment 4 Felix Miata 2018-06-11 18:10:41 UTC
mailing list post
https://lists.opensuse.org/opensuse/2018-06/msg00510.html
says: "...failed to upgrade a test partition with Leap 42.3 to 15.0, using the DVD method. First it aborted because it found reiserfs partitions in fstab, even though they were references to quite old openSUSE installs on other partitions. Like 13.1. Obviously I can not change them....I had to comment them out. :-/ I rebooted and tried again, and after it started probing the target partition, yast crashed."
Comment 5 Knut Alejandro Anderssen González 2018-06-12 14:16:16 UTC
Ivan was working on it and probably should be fixed in yast2-storage-ng-4.0.187 and yast2-update-4.0.16

*** This bug has been marked as a duplicate of bug 1094963 ***
Comment 6 Carlos Robinson 2018-06-12 20:00:44 UTC
(In reply to Knut Alejandro Anderssen González from comment #5)
> Ivan was working on it and probably should be fixed in
> yast2-storage-ng-4.0.187 and yast2-update-4.0.16
> 
> *** This bug has been marked as a duplicate of bug 1094963 ***

Notice that this bug hits when YaST reads the partition to upgrade, not when asking for encryption password. And that disk does not contain any encrypted partition, they are on other disks.

I'm not sure that this bug is a duplicate of bug 1094963
Comment 7 Knut Alejandro Anderssen González 2018-06-12 20:50:28 UTC
Reopen it by now until I get tomorrow more information from Ivan to know if he also fixed this situation or not.

At least, the proper exception handling should be related.

https://github.com/openSUSE/libstorage-ng/pull/535
Comment 8 José Iván López González 2018-06-13 07:58:33 UTC
(In reply to Carlos Robinson from comment #6)
> (In reply to Knut Alejandro Anderssen González from comment #5)
> > Ivan was working on it and probably should be fixed in
> > yast2-storage-ng-4.0.187 and yast2-update-4.0.16
> > 
> > *** This bug has been marked as a duplicate of bug 1094963 ***
> 
> Notice that this bug hits when YaST reads the partition to upgrade, not when
> asking for encryption password. And that disk does not contain any encrypted
> partition, they are on other disks.
> 
> I'm not sure that this bug is a duplicate of bug 1094963

I have checked the logs and this bug is exactly the same as bsc#1094963. When you select the system to upgrade, then the fstab of the selected system is parsed and all devices in the fstab are mounted. The problem is when there is an encryption device in some of the fstab entries. In this case, there are two of them: /dev/mapper/cr_cripta and /dev/mapper/cr_Aux_01. It fails when trying to mount /dev/mapper/cr_cripta.

As commented by Knut, this is fixed with yast2-storage-ng-4.0.187 and yast2-update-4.0.16.

*** This bug has been marked as a duplicate of bug 1094963 ***
Comment 9 Carlos Robinson 2018-06-13 08:23:23 UTC
Ok, thanks :-)

Will this be fixed for "installer Self-update"?
https://github.com/yast/yast-installation/blob/master/doc/SELF_UPDATE.md

«Starting on version 3.1.175, yast2-installation is able to update itself during system installation. This feature will help to solve problems with the installation even after the media has been released.»


Just saying in case it matters:

/dev/mapper/cr_Aux_01 is an external disk that was not connected at the time.

And /dev/mapper/cr_cripta has another problem, because that installation lacked /etc/crypttab. This causes the mount to fail and systemd to complain about missing deps, but besides that the system works.

There are other encrypted partitions not listed in fstab. None in the same disk as "/", which is a relatively small SSD.


(the system was upgraded using zypper dup, anyway, thus not available for testing).
Comment 10 José Iván López González 2018-06-13 11:14:30 UTC
(In reply to Carlos Robinson from comment #9)
> Ok, thanks :-)
> 
> Will this be fixed for "installer Self-update"?
> https://github.com/yast/yast-installation/blob/master/doc/SELF_UPDATE.md
> 
> «Starting on version 3.1.175, yast2-installation is able to update itself
> during system installation. This feature will help to solve problems with
> the installation even after the media has been released.»
> 

I am afraid that openSUSE Leap does not use the self-update feature. But we have another option, and that is to use a live image. Live images are frequently refreshed, so it should include important fixes that affects the installation/upgrade process. You can get a live image going to [1] and selecting the "Live" tab.   

[1] https://software.opensuse.org/distributions/leap

> 
> Just saying in case it matters:
> 
> /dev/mapper/cr_Aux_01 is an external disk that was not connected at the time.
> 
> And /dev/mapper/cr_cripta has another problem, because that installation
> lacked /etc/crypttab. This causes the mount to fail and systemd to complain
> about missing deps, but besides that the system works.
> 

Thanks for the info, it is very useful for us to understand the scenario. After the fix we have provided, I would say that it should continue working with your setup (missing device and also missing crypttab). Probably, you will get some popup alerting about the partition cannot be mounted, but it should not fail. 

> There are other encrypted partitions not listed in fstab. None in the same
> disk as "/", which is a relatively small SSD.
> 
> 
> (the system was upgraded using zypper dup, anyway, thus not available for
> testing).
Comment 11 Ancor Gonzalez Sosa 2018-06-13 11:24:59 UTC
(In reply to José Iván López González from comment #10)
> (In reply to Carlos Robinson from comment #9)
> > Ok, thanks :-)
> > 
> > Will this be fixed for "installer Self-update"?
> > https://github.com/yast/yast-installation/blob/master/doc/SELF_UPDATE.md
> > 
> > «Starting on version 3.1.175, yast2-installation is able to update itself
> > during system installation. This feature will help to solve problems with
> > the installation even after the media has been released.»
> > 
> 
> I am afraid that openSUSE Leap does not use the self-update feature. But we
> have another option, and that is to use a live image. Live images are
> frequently refreshed, so it should include important fixes that affects the
> installation/upgrade process. You can get a live image going to [1] and
> selecting the "Live" tab.   
> 
> [1] https://software.opensuse.org/distributions/leap

Indeed, the Self-update feature needs a repository where to get the updates from. The openSUSE release manager decided that it's better to not have such repository for openSUSE and, thus, to not use the Self-update feature for openSUSE releases.

And indeed the Live images are a valid alternative to enjoy an up-to-date installer for fresh installations. But I don't think the live images can be easily used to perform an update of a previous system.
Comment 12 Carlos Robinson 2018-06-13 12:00:54 UTC
AFAIK, the live images can't be used for upgrades, unless they have been changed.

Does the netinstall CD image download an updated version of YaST?
Comment 13 Richard Brown 2018-06-13 12:23:45 UTC
(In reply to Carlos Robinson from comment #12)
> AFAIK, the live images can't be used for upgrades, unless they have been
> changed.
> 
> Does the netinstall CD image download an updated version of YaST?

The live images now use the same installer as the netinstall

Both should be fine for upgrades
Comment 14 Gerry Makaro 2018-06-13 19:35:15 UTC
It might sound silly for me to ask this, from what I read here, but:

You mean, "self_update=1" does not work in the 15.0 installer, in spite of the linuxrc documentation?

Personally, I think this should be readressed:

"Indeed, the Self-update feature needs a repository where to get the updates from. The openSUSE release manager decided that it's better to not have such repository for openSUSE and, thus, to not use the Self-update feature for openSUSE releases."

... and corrected.
Comment 15 Ancor Gonzalez Sosa 2018-06-14 11:45:18 UTC
(In reply to Gerry Makaro from comment #14)
> It might sound silly for me to ask this, from what I read here, but:
> 
> You mean, "self_update=1" does not work in the 15.0 installer, in spite of
> the linuxrc documentation?

Yes, that's what I mean. Self-update has never been enabled for openSUSE. Linuxrc recognizes the parameter and YaST supports it (that's why its documented in the Linuxrc page). But that is only useful if the distribution being installed has the corresponding infrastructure and configuration in place. So far, that's true for SLE but not for openSUSE.

Of course, anyone can also setup his/her own Self-update repository. Another good reason to have the mechanism documented.

> Personally, I think this should be readressed:
> 
> "Indeed, the Self-update feature needs a repository where to get the updates
> from. The openSUSE release manager decided that it's better to not have such
> repository for openSUSE and, thus, to not use the Self-update feature for
> openSUSE releases."
> 
> ... and corrected.

Well, the repository and the configuration are not there due to an informed and conscious decision (just in case I made it sound like it was some kind of error or a lack of resources, that was not my intention). Of course, you are free to open a public discussion about it in the appropriate channels or with the appropriate people.
Comment 16 José Iván López González 2018-06-20 10:49:39 UTC
(In reply to Carlos Robinson from comment #9)
> Ok, thanks :-)
> 
> Will this be fixed for "installer Self-update"?
> https://github.com/yast/yast-installation/blob/master/doc/SELF_UPDATE.md

Regarding this, please, take a look to this comment from Ancor: https://bugzilla.suse.com/show_bug.cgi?id=1094749#c21