|
Bugzilla – Full Text Bug Listing |
| Summary: | Install yast icons with module, instead of yast-theme | ||
|---|---|---|---|
| Product: | [openSUSE] openSUSE Tumbleweed | Reporter: | Sasi Olin <hel> |
| Component: | YaST2 | Assignee: | E-mail List <yast2-maintainers> |
| Status: | RESOLVED FEATURE | QA Contact: | Jiri Srain <jsrain> |
| Severity: | Normal | ||
| Priority: | P5 - None | CC: | jcheung, noahadvs |
| Version: | Current | ||
| Target Milestone: | --- | ||
| Hardware: | Other | ||
| OS: | Other | ||
| Whiteboard: | |||
| Found By: | --- | Services Priority: | |
| Business Priority: | Blocker: | --- | |
| Marketing QA Status: | --- | IT Deployment: | --- |
| Bug Depends on: | |||
| Bug Blocks: | 1081517 | ||
|
Description
Sasi Olin
2018-09-21 14:21:25 UTC
From my point of view this would defeat the purpose of themes. The theme package can be different e.g. per product. If the icons would be included in the individual packages all those 100 packages would need modifications instead of the one theme package. It's not like YaST themes, apart from hicolor, are maintained anyway, and that issue you are mentioning is valid for every single icon theme trying to maintain compatibility with YaST will have to do sooner or later. I would understand the concern if there existed a version of Breeze icon theme apart from YaST hicolor, but it doesn't. Actually, the current scheme makes it harder to create YaST icon theme, because yast-theme contains icons that are no longer used, and it's not clear which icons YaST actually uses. Putting all required icons within modules will make it clear which icons are used for which module, and depending on either it's actually being used in an active module and doesn't happen to show up in depreciated module, it can be added to a theme. Asking Noah, who is working on YaST Breeze icons about supportability of YaST themes as is. As someone who is making KDE Breeze icons for YaST, I agree with Stasiek for a couple main reasons. 1. It would help us eliminate icons we no longer need, which removes uncertainty about whether or not some the work we're doing is a waste of time. 2. It would discourage inappropriate reuse of existing YaST icons and hopefully encourage the use of icons that are included with most themes. Some icons are reused in ways that don't make a lot of sense. Some YaST modules use icons that once belonged to a module that is now long gone, but the name of the icon stayed the same. That makes it more difficult to figure out what modules use what icons. I think this needs some broader discussion as each approach has some advantages and disadvantages. Theme packages: + Easy to change the look globally with a single package (SLE vs. openSUSE theme) + No icon duplication, the icons can be shared easily - Hard to maintain for designers, unused icons cannot be easily found, names might not match Bundled icons in YaST: + No unused icons, proper names - How to share the icons? How to update the same icon used in several modules? - How to make styling for 3rd party distributions easy? (Think about Novell/Microfocus Open Enterprise Server based on SUSE Enterprise Server but with different branding) I think this should be discussed in https://features.opensuse.org/ or probably better at yast-devel ML (https://lists.opensuse.org/yast-devel/) Answered basically the same thing in https://bugzilla.suse.com/show_bug.cgi?id=1110236#c2 This is an autogenerated message for OBS integration: This bug (1109310) was mentioned in https://build.opensuse.org/request/show/653861 Factory / patterns-kde openSUSE-SU-2020:0676-1: An update that solves one vulnerability and has 6 fixes is now available. Category: security (moderate) Bug References: 1109310,1133045,1140711,1164105,1168123,1168281,1170082 CVE References: CVE-2019-18905 Sources used: openSUSE Leap 15.1 (src): autoyast2-4.1.15-lp151.2.12.1 This is an autogenerated message for OBS integration: This bug (1109310) was mentioned in https://build.opensuse.org/request/show/844234 Factory / yast2-registration |