Bug 1128195

Summary: gnome-control-center -- Patches needs dropping or rebase
Product: [openSUSE] openSUSE Tumbleweed Reporter: Bjørn Lie <bjorn.lie>
Component: GNOMEAssignee: Jonathan Kang <songchuan.kang>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None CC: yfjiang
Version: Current   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: Yes
Marketing QA Status: --- IT Deployment: ---
Bug Depends on:    
Bug Blocks: 1128190    

Description Bjørn Lie 2019-03-06 16:45:59 UTC
Patches in gnome-control-center needs dropping or rebase.
Comment 1 Yifan Jiang 2019-03-19 00:31:17 UTC
Hi Jonathan,

It looks mostly on gnome-control-center-disable-error-message-for-NM.patch at the moment, could you help on that please? Thank you!
Comment 2 Bjørn Lie 2019-03-22 18:10:37 UTC
Thanks for the rebased patch, however in GNOME:Next we run meson_test as part of check, and the rebased patch leads to tests to fail.

I have for now disabled meson_test, but a patch that allows the tests to pass would have been nice :-)

https://build.opensuse.org/package/show/GNOME:Next/gnome-control-center
Comment 3 Swamp Workflow Management 2019-03-26 10:00:07 UTC
This is an autogenerated message for OBS integration:
This bug (1128195) was mentioned in
https://build.opensuse.org/request/show/687775 Factory / gnome-control-center
Comment 4 Jonathan Kang 2019-04-01 09:07:35 UTC
(In reply to Bjørn Lie from comment #2)
> Thanks for the rebased patch, however in GNOME:Next we run meson_test as
> part of check, and the rebased patch leads to tests to fail.
> 
> I have for now disabled meson_test, but a patch that allows the tests to
> pass would have been nice :-)
> 
> https://build.opensuse.org/package/show/GNOME:Next/gnome-control-center

Enabling tests for network panel will call g_dbus_proxy_new_sync() which is added
in gnome-control-center-disable-error-message-for-NM.patch. And this dbus
function call fails. My guess is the build machine doesn't have dbus service
available.

So disable tests for network panel in the patch.
https://build.opensuse.org/request/show/690294
Comment 5 Jonathan Kang 2019-04-08 06:06:56 UTC
RESOLVED FIXED.