Bug 1129586

submitted for SLE-12 (rq 187436)/SLE-15 (rq 187435)/Factory (rq 686400)

(In reply to Ruediger Oertel from comment #1)
> submitted for SLE-12 (rq 187436)/SLE-15 (rq 187435)/Factory (rq 686400)

That fix might be applicable to SLE12 - but at least on Factory it is not true, as the bug does not exist to start with.

The .pc file on Tumbleweed (libspeechd-devel-0.9.0-1.1.x86_64.rpm) already contains:

  prefix=/usr
  exec_prefix=/usr
  libdir=/usr/lib64
  includedir=/usr/include/speech-dispatcher

The submission only adds one more nested subdirectory, moving the headers to /usr/include/speech-dispatcher/speech-dispatcher (technically not wrong, but not what we aim for)

If this is still applicable on SLE15, then this would imply that speech-dispatcher 0.9.0 brought the fix for this to Tumbleweed.

For reference, this was fixed upstream with

https://github.com/brailcom/speechd/commit/e79b0531173e9dd4892b46a8b9cc11e8f8156e9c#diff-67e997bcfdac55191033d57a16d1408a (in the 0.8 branch)

So it's broken upstream too, aaagh

@Dominique Leuenberger: I'm working (qam-sle) on RR 187684 for SLE 15 and, as you wrote, the submission indeed added a nested subdir:

before:
  includedir=/usr/include/speech-dispatcher

after:
  includedir=/usr/include/speech-dispatcher/speech-dispatcher

Just to be sure, are we good with it?

(In reply to Paolo Stivanin from comment #6)
> @Dominique Leuenberger: I'm working (qam-sle) on RR 187684 for SLE 15 and,
> as you wrote, the submission indeed added a nested subdir:
> 
> before:
>   includedir=/usr/include/speech-dispatcher
> 
> after:
>   includedir=/usr/include/speech-dispatcher/speech-dispatcher
> 
> Just to be sure, are we good with it?

As far as I've seen, this was indeed an issue with SLE12 (as the bug is reported against) - but for SLE15, a newer version of speech-dispatcher is in use that addressed the error. So no patches should be required on SLE15 and beyond.

Does that patch what you observe?

Yep, it's all good!

SUSE-RU-2019:0895-1: An update that has one recommended fix can now be installed.

Category: recommended (moderate)
Bug References: 1129586
CVE References: 
Sources used:
SUSE Linux Enterprise Module for Open Buildservice Development Tools 15 (src):    speech-dispatcher-0.8.8-3.3.2
SUSE Linux Enterprise Module for Desktop Applications 15 (src):    speech-dispatcher-0.8.8-3.3.2

*** NOTE: This information is not intended to be used for external
    communication, because this may only be a partial fix.
    If you have questions please reach out to maintenance coordination.

SUSE-RU-2019:0902-1: An update that has one recommended fix can now be installed.

Category: recommended (moderate)
Bug References: 1129586
CVE References: 
Sources used:
SUSE Linux Enterprise Software Development Kit 12-SP4 (src):    speech-dispatcher-0.8-10.3.1
SUSE Linux Enterprise Software Development Kit 12-SP3 (src):    speech-dispatcher-0.8-10.3.1
SUSE Linux Enterprise Server 12-SP4 (src):    speech-dispatcher-0.8-10.3.1
SUSE Linux Enterprise Server 12-SP3 (src):    speech-dispatcher-0.8-10.3.1
SUSE Linux Enterprise Desktop 12-SP4 (src):    speech-dispatcher-0.8-10.3.1
SUSE Linux Enterprise Desktop 12-SP3 (src):    speech-dispatcher-0.8-10.3.1

*** NOTE: This information is not intended to be used for external
    communication, because this may only be a partial fix.
    If you have questions please reach out to maintenance coordination.

Ok, so now 0.8-10.3.1 seems to have a new problem.

The includedir is this:
includedir=/usr/include/speech-dispatcher

But as mentioned, the code is now under
/usr/include/speech-dispatcher/speech-dispatcher

So by trying to use these libraries with "-isystem /usr/include/speech-dispatcher", my code will fail at "fatal error: libspeechd.h: No such file or directory".

If I modify the includedir to have the nested folder structure:
includedir=/usr/include/speech-dispatcher/speech-dispatcher
The code will fail at libspeechd.h including speechd_types.h from <speech-dispatcher/speechd_types.h>. 

The easiest solution to fix this latest problem is for me to just "sudo mv /usr/include/speech-dispatcher/speech-dispatcher/* /usr/include/speech-dispatcher/" and this time not touch the .pc file at all, but I think you want to fix this for the packages as well.

*** Bug 1132088 has been marked as a duplicate of this bug. ***

okay, thankfully this was already fixed for factory.
the first fix was correct for sle12
and for sle15 and thus leap15 I'll submit the reverting change now.

SLE15: created request id 190396

openSUSE-RU-2019:1214-1: An update that has one recommended fix can now be installed.

Category: recommended (moderate)
Bug References: 1129586
CVE References: 
Sources used:
openSUSE Leap 15.0 (src):    speech-dispatcher-0.8.8-lp150.2.3.1

openSUSE-RU-2019:1424-1: An update that has one recommended fix can now be installed.

Category: recommended (moderate)
Bug References: 1129586
CVE References: 
Sources used:
openSUSE Leap 15.1 (src):    speech-dispatcher-0.8.8-lp151.3.3.1

SUSE-RU-2019:1327-1: An update that has one recommended fix can now be installed.

Category: recommended (moderate)
Bug References: 1129586
CVE References: 
Sources used:
SUSE Linux Enterprise Module for Open Buildservice Development Tools 15 (src):    speech-dispatcher-0.8.8-3.6.3
SUSE Linux Enterprise Module for Desktop Applications 15 (src):    speech-dispatcher-0.8.8-3.6.3

NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination.

openSUSE-RU-2019:1480-1: An update that has one recommended fix can now be installed.

Category: recommended (moderate)
Bug References: 1129586
CVE References: 
Sources used:
openSUSE Leap 15.1 (src):    speech-dispatcher-0.8.8-lp151.3.6.1
openSUSE Leap 15.0 (src):    speech-dispatcher-0.8.8-lp150.2.6.1

SUSE-RU-2019:1327-2: An update that has one recommended fix can now be installed.

Category: recommended (moderate)
Bug References: 1129586
CVE References: 
Sources used:
SUSE Linux Enterprise Module for Open Buildservice Development Tools 15-SP1 (src):    speech-dispatcher-0.8.8-3.6.3
SUSE Linux Enterprise Module for Desktop Applications 15-SP1 (src):    speech-dispatcher-0.8.8-3.6.3

NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination.