Bug 113646

Summary:	New acpi_hotkeys_ASUS_M6842NW script
Product:	[openSUSE] SUSE LINUX 10.0	Reporter:	Forgotten User v5inq2MBSE <forgotten_v5inq2MBSE>
Component:	Other	Assignee:	Forgotten User ZhJd0F0L3x <forgotten_ZhJd0F0L3x>
Status:	VERIFIED FIXED	QA Contact:	E-mail List <qa-bugs>
Severity:	Enhancement
Priority:	P5 - None
Version:	Beta 3
Target Milestone:	---
Hardware:	32bit
OS:	SUSE Other
URL:	http://www.iiv.de/schwinde/buerger/tremmel/downloads/SuSE_9.3/acpi_hotkeys_ASUS_M6842NW
Whiteboard:
Found By:	Beta-Customer	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Attachments:	patch against your version new version, fixing touchpad on/off on SUSE 10

Description Forgotten User v5inq2MBSE 2005-08-28 15:55:55 UTC

In SuSE 9.3 you've integrated my acpi_hotkeys_ASUS_M6842NW script into the  
powersave package. In 10.0beta3 the script wasn't updated. Inbetween I've made  
some improvements:  
  
- faster media detection  
- switching on/off wlan works  
- switching on/off touchpad works (using synclient using synaptics packman  
  rpm for SUSE 9.3 and x11-input-synaptics in SUSE 10.0)  
- using powergear key to switch powersave states  
  
Would be nice, to see the new version in SUSE 10, the URL is a link to the 
script.

Comment 1 Forgotten User ZhJd0F0L3x 2005-08-29 15:49:47 UTC

Created attachment 48033 [details]
patch against your version

This patch does some cosmetic (comments, ...) and some functional changes (exit
=> EXIT etc, see the comments in
http://forge.novell.com/modules/xfmod/cvs/cvsbrowse.php/powersave/powersave/contrib/example_event_script?rev=HEAD&content-type=text/vnd.viewcvs-markup
 for an explanation).
Not sure if it will get into beta4, but it will be in final.

Comment 2 Forgotten User v5inq2MBSE 2005-08-29 19:16:47 UTC

Thanks, at the moment I haven't updated my Laptop, to SUSE 10, so including 
x_helper_functions doesn't work (no ${SCRIPT_DIR}), I've changed it for me to 
${0%/*} and tested without any problems. 
I think, next weekend is the time to update my Notebook, too ;-)

Comment 3 Forgotten User ZhJd0F0L3x 2005-08-29 19:56:30 UTC

BTW: the idea behind this $SCRIPT_DIR stuff etc is, to make the powersave
package more portable and relocatable. I probably will set SCRIPT_DIR in the
environment from the daemon before starting the scripts in the future.
This makes it possible to do a "./configure
--with-scripts-dir=/foo/bar/powersave" and _not_ needing to change all scripts etc.

Also, the change in SCRIPT_RETURN-syntax was not decided on easily (that's why
we still have the old as compatibility band-aid), but it just makes sense: the
old protocol via the socket just pushed that pipe-separated string over a socket
connection; today, we use DBUS and send objects over the bus so there is no need
for the extra "pipe-protocol" and parsing strings in a daemon running as root is
always dangerous :-), so we moved the parsing into script_return and will remove
it some time in the future (after a deprecation period and Log messages warning
before the fact).

Just to keep you updated :-)

Comment 4 Forgotten User v5inq2MBSE 2005-09-12 19:42:47 UTC

Created attachment 49677 [details]
new version, fixing touchpad on/off on SUSE 10

Sorry, I have to send another fix, but the old touchpad on/off version only
worked on SUSE 9.3, my fault.
Wouldn*t it be nice to set execution bit at the scripts in
/usr/share/doc/packages/contrib/? They could be linked into
/usr/lib/powersave/scripts/ and needn't be copied, so users could get new
versions when updating powersave without doing anything.

Comment 5 Forgotten User ZhJd0F0L3x 2005-09-13 10:50:33 UTC

we could do this, but i think that those acpi hotkeys should be handled with ial
and initial instead of powersaved anyway, so i'll consider this with low
priority ;-)

Comment 6 Forgotten User ZhJd0F0L3x 2005-09-16 09:18:47 UTC

btw: this will probably be in an YOU once GM is out