Bug 114648

Summary:	Suspend to Disk broken for SATA hard drives with kotd-20050831104926
Product:	[openSUSE] SUSE LINUX 10.0	Reporter:	Stefan Behlert <behlert>
Component:	Kernel	Assignee:	Jens Axboe <axboe>
Status:	RESOLVED FIXED	QA Contact:	E-mail List <qa-bugs>
Severity:	Blocker
Priority:	P5 - None
Version:	Beta 4
Target Milestone:	---
Hardware:	Other
OS:	All
Whiteboard:
Found By:	Other	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Attachments:	photo of crash

Description Stefan Behlert 2005-09-01 08:29:12 UTC

I tested the kotd-20050831104926 as mentioned in bug 104647 
and had a kerneloops during suspend to disk.  
I'll append a jpeg from the crash, it says "kernel BUG at 
drivers/scsi/libata-core.c:3742!" at first line.

Comment 1 Stefan Behlert 2005-09-01 08:30:02 UTC

Created attachment 48420 [details]
photo of crash

Comment 2 Stefan Behlert 2005-09-01 08:32:11 UTC

The Acer used for the test is the one described in bug 104647

Comment 3 Jens Axboe 2005-09-01 10:22:06 UTC

Lovely! I'll add a work-around.

Comment 4 Jens Axboe 2005-09-01 10:27:43 UTC

Committed, please test the next kotd that shows up. It should have this in the
changelog:

Thu Sep  1 12:26:49 CEST 2005 - axboe@suse.de

- patches.drivers/libata-do-simple-command-sleep-hack: Wait for
  current command to finish in ata_do_simple_cmd() (114648).
- series.conf:

Just grep for the bug number, that should work.

Comment 5 Stefan Behlert 2005-09-02 10:11:56 UTC

Ok, tested with kotd-20050831104926 (which contains the mentioned patch):    
suspend2disk: suspend works, I get more warnings than in the past,     
              but the 'pause' mentioned in bug 113335 was gone!    
suspend2ram:  init=/bin/bash acpi_sleep=s3_bios,s3_mode looks good, resumes.   
                 Even a ls was successful.   
              'normal init 5'-state with acpi_sleep=s3_bios,s3_mode:    
               the machine resumes, but display stays black. Looks not   
               connected to SATA and this bug, so I would say 'FIXED'.   
               (And I even saw the black display only once, afterwards  
               it worked perfectly)    
Thanks, good work.