Bug 115297

Summary:	yast2-mail: silent failures in changing the effective Postfix configuration
Product:	[openSUSE] SUSE LINUX 10.0	Reporter:	Heiko Rommel <heiko.rommel>
Component:	YaST2	Assignee:	Peter Varkoly <varkoly>
Status:	RESOLVED WONTFIX	QA Contact:	Klaus Kämpf <kkaempf>
Severity:	Normal
Priority:	P5 - None
Version:	Beta 4
Target Milestone:	---
Hardware:	Other
OS:	SUSE Other
Whiteboard:
Found By:	Component Test	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---

Description Heiko Rommel 2005-09-05 12:22:39 UTC

In case the background "SuSEconfig -module" fails to write the effective Postfix
configuration (may be because the file has been changed manually) no error is
displayed to the admin.

I think this is a real bug.
There are admins that rely on yast2 modules to work.

Comment 1 Martin Vidner 2005-09-05 13:46:41 UTC

The code is supposed to display an error popup. Please be more specific - what 
file did you change manually? Attach y2logs: 
http://opensuse.org/index.php/Bug_Reporting_FAQ#YaST

Comment 2 Martin Vidner 2006-09-05 08:37:03 UTC

I have reproduced the problem:
I have manually changed message_size_limit in main.cf and then tried to change 
masquerade_domains using yast2 mail. It failed silently.

I think that the problem is that "SuSEconfig --module postfix" returns 0 in this case. It should return an error.
Well, the manual page SuSEconfig(8) does not specify it, but that is another bug.

mjolnir:~ # diff -u /etc/postfix/main.cf.SuSEconfig /etc/postfix/main.cf
--- /etc/postfix/main.cf.SuSEconfig     2006-09-05 11:07:46.000000000 +0200
+++ /etc/postfix/main.cf        2006-09-05 11:06:43.000000000 +0200
@@ -665,7 +665,7 @@
 myhostname = mjolnir.suse.cz
 program_directory = /usr/lib/postfix
 inet_interfaces = 127.0.0.1 ::1
-masquerade_domains = suse.cz
+masquerade_domains =
 mydestination = $myhostname, localhost.$mydomain
 defer_transports =
 mynetworks_style = subnet
@@ -688,4 +688,4 @@
 alias_maps = hash:/etc/aliases
 mailbox_size_limit = 0
 # arbitrary change to confuse suseconfig, https://bugzilla.novell.com/show_bug.cgi?id=115297
-message_size_limit = 10240000
+message_size_limit = 10250000
mjolnir:~ # SuSEconfig --module postfix
Starting SuSEconfig, the SuSE Configuration Tool...
Running module postfix only
Reading /etc/sysconfig and updating the system...
Executing /sbin/conf.d/SuSEconfig.postfix...
        *** WARNING ***
Found /etc/postfix/main.cf.SuSEconfig, exiting...
        *** WARNING ***
Finished.
mjolnir:~ # echo $?
0

Comment 3 Peter Varkoly 2006-10-24 07:02:57 UTC

The problem is, that check_md5_and_move do not recognise the caller if the file was written or not. So if the user has modified the configuration file manualy check_md5_and_move do not wirte the file but the modul called it will not find it out.

Comment 4 Peter Varkoly 2006-12-08 12:50:31 UTC

Without fixing check_md5_and_move I can not do anything.
The best way is, yast2-mail have to look if /etc/postfix/main.cf.SuSEconfig, if so the user have to get a warning, that the original /etc/postfix/main.cf was not configured.

Can you conceive a new option for SuSEconfig -force-write.
Whit this option the configuration files would be overwritten.

Comment 5 Peter Varkoly 2006-12-20 11:39:40 UTC

withouth fixing check_md5_and_move I can not do anything.