Bug 115467

Summary:	automatic cd detection thows icon of cd over existing gnome desktop icons
Product:	[openSUSE] SUSE LINUX 10.0	Reporter:	Joe Harmon <jharmon>
Component:	GNOME	Assignee:	Federico Mena Quintero <federico>
Status:	VERIFIED FIXED	QA Contact:	E-mail List <qa-bugs>
Severity:	Normal
Priority:	P2 - High
Version:	Beta 4 Plus
Target Milestone:	---
Hardware:	Other
OS:	All
Whiteboard:
Found By:	Other	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Attachments:	before the cd is put in after the cd is put in gnome-vfs2-115467-remove-deleted-file-metadata.diff Patch for (3) above

Description Joe Harmon 2005-09-06 18:31:07 UTC

I put in a CD and it is autodetected. Then when it throws the icon on the
destkop, it doen't refresh, it just throws it on top of whatever is already there.

I will include a screen shot.

Comment 1 Joe Harmon 2005-09-06 18:31:28 UTC

Created attachment 48988 [details]
before the cd is put in

Comment 2 Joe Harmon 2005-09-06 18:31:43 UTC

Created attachment 48989 [details]
after the cd is put in

Comment 3 Federico Mena Quintero 2005-09-21 18:45:24 UTC

Yeah, this is quite annoying.

I need to look at the icon positioning code in detail.  It may also be that some
metadata about previously-used icons is not cleaned up properly.

Comment 4 Federico Mena Quintero 2005-09-21 18:49:07 UTC

Oooh, another really old upstream bug:
http://bugzilla.gnome.org/show_bug.cgi?id=45953

Comment 5 Federico Mena Quintero 2005-11-04 02:17:04 UTC

Bah, this is three different bugs that have the same visual effect (overlapped icons).

Bug 1:

  cd ~/Desktop
  touch foo       <- icon appears
  right-click on foo
  select "Delete" instead of "Move to trash" <- icon disappears
  touch bar       <- icon appears where foo used to be
  touch foo       <- icon appears, overlapping bar

Bug 2:

  cd ~/Desktop
  touch foo       <- icon appears
  rm foo          <- icon disappears
  touch bar       <- icon appears where foo used to be
  touch foo       <- icon appears, overlapping bar

Bug 3:

  the CD-ROM thing

I have a fix for (1), and I'm looking for (2) and (3).

Comment 6 Federico Mena Quintero 2005-11-04 02:18:25 UTC

Created attachment 56444 [details]
gnome-vfs2-115467-remove-deleted-file-metadata.diff

Patch for Bug (1) above.

Comment 7 Federico Mena Quintero 2005-11-08 01:19:03 UTC

Created attachment 56645 [details]
Patch for (3) above

This makes Nautilus not overlap the volume icons.  It turns out that it already had code to test for overlaps, but it was a bit hard to find.  Also, a test was being too zealous on whether to  use the already-stored position for a volume icon.

Comment 8 Federico Mena Quintero 2005-11-08 02:12:20 UTC

Submitted all the patches to autobuild for STABLE and PLUS.  This will be in gnome-vfs2-2.12.1.1-2 or later, and nautilus-2.12.1-4 or later.