Bug 1160295

Well, sysfsutils certainly has issues, as nobody is maintaining it upstream at all, and now evidently I own it in SUSE.

None of the issues, though, have to do with "-fno-common".

Never the less, I submitted upstream all of my changes to fix all build issues, but I suspect the pull request will just sit.

I will give it a week or so, and if no response there I will just fix the SUSE package(s) with a patch.

But, to do this correctly, somebody should fork that package upstream and maintain the changes there.

Yes, please send a SR to the devel project.

Marking as resolved.

Note that the staging was moved to:
https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:N/sysfsutils/standard/x86_64

I don't see a fix in the devel project, Lee?

(In reply to Martin Liška from comment #4)
> Note that the staging was moved to:
> https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:N/
> sysfsutils/standard/x86_64
> 
> I don't see a fix in the devel project, Lee?

The fix for this is in Base:System and in openSUSE:Factory.

I have no idea how and when the factory build folks move it from openSUSE:Factory to a release. But I just checked my tumbleweed release, and the fix is there already.

Re-closing the bug.

(In reply to Lee Duncan from comment #5)
> (In reply to Martin Liška from comment #4)
> > Note that the staging was moved to:
> > https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:N/
> > sysfsutils/standard/x86_64
> > 
> > I don't see a fix in the devel project, Lee?
> 
> The fix for this is in Base:System and in openSUSE:Factory.
> 
> I have no idea how and when the factory build folks move it from
> openSUSE:Factory to a release. But I just checked my tumbleweed release, and
> the fix is there already.
> 
> Re-closing the bug.

Thank you, fixing that in the development project is what I need.

There are another failures:

https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:N/sysfsutils/standard/x86_64

[   80s] gcc -Wall -W -Wextra -Wstrict-prototypes -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -flto=auto -o .libs/testlibsysfs test.o test_attr.o test_bus.o test_class.o test_device.o test_driver.o test_module.o test_utils.o testout.o  ../lib/.libs/libsysfs.so
[   80s] /usr/lib64/gcc/x86_64-suse-linux/10/../../../../x86_64-suse-linux/bin/ld: test_attr.o (symbol from plugin): in function `my_stdout':
[   80s] (.text+0x0): multiple definition of `my_stdout'; test.o (symbol from plugin):(.text+0x0): first defined here
[   80s] /usr/lib64/gcc/x86_64-suse-linux/10/../../../../x86_64-suse-linux/bin/ld: test_bus.o (symbol from plugin): in function `my_stdout':
[   80s] (.text+0x0): multiple definition of `my_stdout'; test.o (symbol from plugin):(.text+0x0): first defined here
[   80s] /usr/lib64/gcc/x86_64-suse-linux/10/../../../../x86_64-suse-linux/bin/ld: test_class.o (symbol from plugin): in function `my_stdout':
[   80s] (.text+0x0): multiple definition of `my_stdout'; test.o (symbol from plugin):(.text+0x0): first defined here
[   80s] /usr/lib64/gcc/x86_64-suse-linux/10/../../../../x86_64-suse-linux/bin/ld: test_device.o (symbol from plugin): in function `my_stdout':
[   80s] (.text+0x0): multiple definition of `my_stdout'; test.o (symbol from plugin):(.text+0x0): first defined here
[   80s] /usr/lib64/gcc/x86_64-suse-linux/10/../../../../x86_64-suse-linux/bin/ld: test_driver.o (symbol from plugin): in function `test_sysfs_close_driver':
[   80s] (.text+0x0): multiple definition of `my_stdout'; test.o (symbol from plugin):(.text+0x0): first defined here
[   80s] /usr/lib64/gcc/x86_64-suse-linux/10/../../../../x86_64-suse-linux/bin/ld: test_module.o (symbol from plugin): in function `test_sysfs_close_module':
[   80s] (.text+0x0): multiple definition of `my_stdout'; test.o (symbol from plugin):(.text+0x0): first defined here
[   80s] /usr/lib64/gcc/x86_64-suse-linux/10/../../../../x86_64-suse-linux/bin/ld: test_utils.o (symbol from plugin): in function `test_sysfs_get_mnt_path':
[   80s] (.text+0x0): multiple definition of `my_stdout'; test.o (symbol from plugin):(.text+0x0): first defined here
[   80s] /usr/lib64/gcc/x86_64-suse-linux/10/../../../../x86_64-suse-linux/bin/ld: testout.o (symbol from plugin): in function `my_stdout':
[   80s] (.text+0x0): multiple definition of `my_stdout'; test.o (symbol from plugin):(.text+0x0): first defined here

I've just made a SR#798386.

Fixed in devel project again now.