Bug 1160296

Summary: tcsh fails with -fno-common
Product: [openSUSE] openSUSE Tumbleweed Reporter: Martin Liška <martin.liska>
Component: BasesystemAssignee: Dr. Werner Fink <werner>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None CC: alynx.zhou, martin.liska
Version: Current   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Bug Depends on:    
Bug Blocks: 1160244    

Description Martin Liška 2020-01-07 14:06:02 UTC
The package fails here:
https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:M/tcsh/standard/x86_64

Please take a look at the META issue for the instructions.
Comment 1 Dr. Werner Fink 2020-01-08 10:52:57 UTC
(In reply to Martin Liška from comment #0)
> The package fails here:
> https://rudin.suse.de:8894/package/live_build_log/openSUSE:Factory:Staging:M/
> tcsh/standard/x86_64
> 
> Please take a look at the META issue for the instructions.

??? I do not see how handle_interrupt can occur in sh.o aka sh.c

 werner/tcsh> grep -rs handle_interrupt tcsh-6.22.02
 tcsh-6.22.02/Fixes: 38. rename handle_intr -> handle_interrupt as originally intended.
 tcsh-6.22.02/sh.h:EXTERN int    handle_interrupt IZERO;/* Are we currently handling an interrupt? */
 tcsh-6.22.02/sh.print.c:    if (handle_interrupt)
 tcsh-6.22.02/sh.print.c:        if (handle_interrupt)
 tcsh-6.22.02/sh.print.c:            if (handle_interrupt == 0)
 tcsh-6.22.02/sh.print.c:            if (handle_interrupt)
 tcsh-6.22.02/tc.sig.c:int handle_interrupt; /* = 0; */
 tcsh-6.22.02/tc.sig.c:  handle_interrupt++;
 tcsh-6.22.02/tc.sig.c:  handle_interrupt--;
 tcsh-6.22.02/tc.sig.c:  handle_interrupt++;
 tcsh-6.22.02/tc.sig.c:  handle_interrupt--;
 tcsh-6.22.02/tc.sig.c:  handle_interrupt++;
 tcsh-6.22.02/tc.sig.c:  handle_interrupt--;
 tcsh-6.22.02/tc.sig.c:  handle_interrupt++;
 tcsh-6.22.02/tc.sig.c:  handle_interrupt--;

Beside this, it compiles Base:System aka I guess that in openSUSE:Factory:Staging:M a new compiler is tested?
Comment 2 Martin Liška 2020-01-08 11:53:38 UTC
(In reply to Dr. Werner Fink from comment #1)
> (In reply to Martin Liška from comment #0)
> > The package fails here:
> > https://rudin.suse.de:8894/package/live_build_log/openSUSE:Factory:Staging:M/
> > tcsh/standard/x86_64
> > 
> > Please take a look at the META issue for the instructions.
> 
> ??? I do not see how handle_interrupt can occur in sh.o aka sh.c

It comes from sh.h. Looking at the pre-processed file of sh.c:

...
# 506 "sh.h" 2
# 548 "sh.h"
 int chkstop ;
 int didfds ;
 int doneinp ;
 int exiterr ;
 int child ;
 int haderr ;
 int intty ;
 int intact ;
 int justpr ;
 int loginsh ;
 int neednote ;
 int noexec ;
 int pjobs ;
 int setintr ;
 int handle_interrupt ;
...

so for some reason
EXTERN int    handle_interrupt IZERO;/* Are we currently handling an interrupt? */

EXTERN is blank.

> 
>  werner/tcsh> grep -rs handle_interrupt tcsh-6.22.02
>  tcsh-6.22.02/Fixes: 38. rename handle_intr -> handle_interrupt as
> originally intended.
>  tcsh-6.22.02/sh.h:EXTERN int    handle_interrupt IZERO;/* Are we currently
> handling an interrupt? */
>  tcsh-6.22.02/sh.print.c:    if (handle_interrupt)
>  tcsh-6.22.02/sh.print.c:        if (handle_interrupt)
>  tcsh-6.22.02/sh.print.c:            if (handle_interrupt == 0)
>  tcsh-6.22.02/sh.print.c:            if (handle_interrupt)
>  tcsh-6.22.02/tc.sig.c:int handle_interrupt; /* = 0; */
>  tcsh-6.22.02/tc.sig.c:  handle_interrupt++;
>  tcsh-6.22.02/tc.sig.c:  handle_interrupt--;
>  tcsh-6.22.02/tc.sig.c:  handle_interrupt++;
>  tcsh-6.22.02/tc.sig.c:  handle_interrupt--;
>  tcsh-6.22.02/tc.sig.c:  handle_interrupt++;
>  tcsh-6.22.02/tc.sig.c:  handle_interrupt--;
>  tcsh-6.22.02/tc.sig.c:  handle_interrupt++;
>  tcsh-6.22.02/tc.sig.c:  handle_interrupt--;
> 
> Beside this, it compiles Base:System aka I guess that in
> openSUSE:Factory:Staging:M a new compiler is tested?

No, latest stable version gcc9.
Comment 3 Swamp Workflow Management 2020-01-08 12:50:05 UTC
This is an autogenerated message for OBS integration:
This bug (1160296) was mentioned in
https://build.opensuse.org/request/show/761828 Factory / tcsh
Comment 4 Dr. Werner Fink 2020-01-08 13:16:24 UTC
Fixed with SR#761828