Bug 1160399

Summary:	kexec-tools fails with -fno-common
Product:	[openSUSE] openSUSE Tumbleweed	Reporter:	Martin Liška <martin.liska>
Component:	Basesystem	Assignee:	Petr Tesařík <ptesarik>
Status:	RESOLVED FIXED	QA Contact:	E-mail List <qa-bugs>
Severity:	Normal
Priority:	P5 - None	CC:	alynx.zhou, ptesarik
Version:	Current
Target Milestone:	---
Hardware:	Other
OS:	Other
Whiteboard:
Found By:	---	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Bug Depends on:
Bug Blocks:	1160244

Description Martin Liška 2020-01-08 09:41:18 UTC

The package fails here:
https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:M/kexec-tools/standard/x86_64

Please take a look at the META issue for the instructions.

Comment 1 Martin Liška 2020-02-04 11:27:59 UTC

May I please ping this issue?

Comment 2 Martin Liška 2020-03-02 11:58:35 UTC

May I please ping this as we're slowly (but surely) approaching a new GCC release and this will unblock acceptance of the new package into Factory.

Comment 3 Martin Liška 2020-03-23 17:00:16 UTC

Another ping please..

Comment 4 Martin Liška 2020-03-31 11:51:31 UTC

I've just made a SR:
https://build.opensuse.org/request/show/790118

Comment 5 Petr Tesařík 2020-03-31 14:01:47 UTC

I wonder if adding '-fcommon' is the best fix here. The duplicate definition comes from kexec/arch/x86_64/kexec-bzImage64.c, and I don't think it's possible to build kexec-tools without linking in the other file. If that's correct, then this definition should be simply removed from the C file.

Let me investigate.

Comment 6 Martin Liška 2020-03-31 16:39:08 UTC

(In reply to Petr Tesařík from comment #5)
> I wonder if adding '-fcommon' is the best fix here. The duplicate definition
> comes from kexec/arch/x86_64/kexec-bzImage64.c, and I don't think it's
> possible to build kexec-tools without linking in the other file. If that's
> correct, then this definition should be simply removed from the C file.
> 
> Let me investigate.

Yes, that's the preferred solution. I added -fcommon because I waited for quite some time and I don't have a capacity to fix all failing packages right now.

Comment 7 Martin Liška 2020-04-03 05:58:45 UTC

@Petr: Have you made progress with it?

Comment 8 Martin Liška 2020-04-03 06:37:35 UTC

Note that we moved to :N staging project:
https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:N/kexec-tools/standard/x86_64

Comment 9 Petr Tesařík 2020-04-03 12:08:22 UTC

(In reply to Martin Liška from comment #7)
> @Petr: Have you made progress with it?

Not me, but Red Hat did:

https://git.kernel.org/pub/scm/utils/kernel/kexec/kexec-tools.git/commit/?id=cc087b11462af9f971a2c090d07e8d780a867b50

Let me take that patch into Factory, and we should be fine.

Comment 10 Petr Tesařík 2020-04-03 12:22:00 UTC

Submitted.

Comment 11 Swamp Workflow Management 2020-04-03 12:50:05 UTC

This is an autogenerated message for OBS integration:
This bug (1160399) was mentioned in
https://build.opensuse.org/request/show/791187 Factory / kexec-tools