Bug 1160408

Summary:	open-vm-tools fails with -fno-common
Product:	[openSUSE] openSUSE Tumbleweed	Reporter:	Martin Liška <martin.liska>
Component:	Basesystem	Assignee:	Kirk Allan <kallan>
Status:	RESOLVED FIXED	QA Contact:	E-mail List <qa-bugs>
Severity:	Normal
Priority:	P5 - None	CC:	alynx.zhou, okurth
Version:	Current	Flags:	kallan: needinfo? (okurth)
Target Milestone:	---
Hardware:	Other
OS:	Other
Whiteboard:
Found By:	---	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Bug Depends on:
Bug Blocks:	1160244

Description Martin Liška 2020-01-08 09:44:04 UTC

The package fails here:
https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:M/open-vm-tools/standard/x86_64

Please take a look at the META issue for the instructions.

Comment 1 Kirk Allan 2020-01-10 15:20:58 UTC

Hi Oliver, could you take a look at this build warning that gets upgraded to an error and advise how to best to handle this?

It looks like Bool is being seen as an int in one place and a char in the other causing the warning/error.

Comment 2 Oliver Kurth 2020-01-10 17:55:30 UTC

Thanks for reporting. I think 'Bool' is typdef'ed to 'char', but in the C++ code we use the 'boolean' type 'false', for both the second parameter for HgfsUri_ConvertFromPathToHgfsUri() and the return type of File_CreateDirectory().

I notified the developers who own this code.

Comment 3 Oliver Kurth 2020-02-05 00:58:32 UTC

We are not able to reproduce this error in house with the latest OpenSuSE Tumbleweed. Did this build use packages from Tumbleweed or some development versions?

Comment 4 Oliver Kurth 2020-02-05 01:20:18 UTC

FWIW, in for gcc10 in Fedora we had to make these changes (not yet in our code base): https://src.fedoraproject.org/rpms/open-vm-tools/blob/master/f/gcc10-warning.patch .

Comment 5 Martin Liška 2020-02-05 08:34:04 UTC

(In reply to Oliver Kurth from comment #4)
> FWIW, in for gcc10 in Fedora we had to make these changes (not yet in our
> code base):
> https://src.fedoraproject.org/rpms/open-vm-tools/blob/master/f/gcc10-warning.
> patch .

You can test in the openSUSE:Factory:Staging:M staging project.
I bet the patch will help with the issues, please add it.

Comment 8 Kirk Allan 2020-03-13 14:49:48 UTC

The patch from comment #4 has been submitted to SLES 15SP2, 15SP1, 15, 12SP5, 12SP4, and openSUSE Factory.

Comment 9 Swamp Workflow Management 2020-03-20 11:17:41 UTC

SUSE-RU-2020:0736-1: An update that has four recommended fixes can now be installed.

Category: recommended (moderate)
Bug References: 1160408,1162119,1162435,1165955
CVE References: 
Sources used:
SUSE Linux Enterprise Server 12-SP5 (src):    open-vm-tools-11.0.5-4.21.1
SUSE Linux Enterprise Server 12-SP4 (src):    open-vm-tools-11.0.5-4.21.1

NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination.

Comment 10 Martin Liška 2020-03-23 16:59:48 UTC

Is it fixed in devel project please? If so, please close it.

Comment 11 Swamp Workflow Management 2020-03-23 17:17:03 UTC

SUSE-RU-2020:0742-1: An update that has four recommended fixes can now be installed.

Category: recommended (moderate)
Bug References: 1160408,1162119,1162435,1165955
CVE References: 
Sources used:
SUSE Linux Enterprise Module for Desktop Applications 15-SP1 (src):    open-vm-tools-11.0.5-3.14.1
SUSE Linux Enterprise Module for Basesystem 15-SP1 (src):    open-vm-tools-11.0.5-3.14.1

NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination.

Comment 12 Kirk Allan 2020-03-23 19:45:41 UTC

The update is now available in TW and SLES15 SP2.  Marking as fixed.

Comment 13 Swamp Workflow Management 2020-03-28 23:13:36 UTC

openSUSE-RU-2020:0397-1: An update that has four recommended fixes can now be installed.

Category: recommended (moderate)
Bug References: 1160408,1162119,1162435,1165955
CVE References: 
Sources used:
openSUSE Leap 15.1 (src):    open-vm-tools-11.0.5-lp151.2.12.1

Comment 15 Swamp Workflow Management 2022-08-31 19:16:03 UTC

SUSE-SU-2022:2961-1: An update that solves one vulnerability and has four fixes is now available.

Category: security (important)
Bug References: 1160408,1162119,1162435,1165955,1202657
CVE References: CVE-2022-31676
JIRA References: 
Sources used:
SUSE Linux Enterprise Server for SAP 15 (src):    open-vm-tools-11.0.5-150000.3.29.1
SUSE Linux Enterprise High Performance Computing 15-LTSS (src):    open-vm-tools-11.0.5-150000.3.29.1
SUSE Linux Enterprise High Performance Computing 15-ESPOS (src):    open-vm-tools-11.0.5-150000.3.29.1

NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination.