Bug 116558

Summary:	nautilus computer:/// crashes when audio CD is present
Product:	[openSUSE] SUSE LINUX 10.0	Reporter:	Mark Gordon <mtgordon>
Component:	GNOME	Assignee:	Federico Mena Quintero <federico>
Status:	RESOLVED FIXED	QA Contact:	E-mail List <qa-bugs>
Severity:	Critical
Priority:	P5 - None	CC:	aj
Version:	RC 1
Target Milestone:	---
Hardware:	Other
OS:	All
Whiteboard:
Found By:	Other	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Attachments:	nautilus stack trace, alas w/o symbols, bzip2'ed on account of size Updated gnome-vfs-submount.patch

Description Mark Gordon 2005-09-12 16:53:26 UTC

On 64bit, when nautilus shows the "computer:///" URI (e.g. by double-clicking
the "Computer" icon on the desktop, or by right-clicking it and selecting
"Open"), nautilus crashes if an audio CD is in the drive.

The stack trace is huge and likely useless w/o symbols.  I'm going to attach
what I have, then I'll reproduce w/ debuginfo packages installed and attach a
new stack trace.

Comment 1 Mark Gordon 2005-09-12 16:55:01 UTC

Created attachment 49654 [details]
nautilus stack trace, alas w/o symbols, bzip2'ed on account of size

Comment 2 JP Rosevear 2005-09-12 17:23:34 UTC

Robert, my suspicion is that this might be caused by your hal hack to remove
duplicates - slightly better trace:

#0  0x00002aaaaf1f6ef2 in waitpid () from /lib64/tls/libpthread.so.0
#1  0x00002aaaabac3cf7 in libgnomeui_module_info_get ()
   from /opt/gnome/lib64/libgnomeui-2.so.0
#2  <signal handler called>
#3  0x00002aaaafdd17a3 in strcmp () from /lib64/tls/libc.so.6
#4  0x00002aaab913dca8 in get_data_for_drive ()
   from /opt/gnome/lib64/gnome-vfs-2.0/modules/libcomputer.so
#5  0x00002aaab913e0dd in do_open ()
   from /opt/gnome/lib64/gnome-vfs-2.0/modules/libcomputer.so
#6  0x00002aaaadc283df in gnome_vfs_open_uri_cancellable ()
   from /opt/gnome/lib64/libgnomevfs-2.so.0
#7  0x00002aaaadc4386f in gnome_vfs_open_uri ()
   from /opt/gnome/lib64/libgnomevfs-2.so.0
#8  0x00002aaaadc43830 in gnome_vfs_open ()
   from /opt/gnome/lib64/libgnomevfs-2.so.0
#9  0x00002aaaadc4bbc8 in gnome_vfs_read_entire_file ()
   from /opt/gnome/lib64/libgnomevfs-2.so.0
#10 0x00002aaaaabfe6fb in nautilus_directory_async_state_changed (
    directory=0xaf91c0) at nautilus-directory-async.c:3038

Its strcmp'ing the drive/volume display names and one of them is NULL.

Comment 3 JP Rosevear 2005-09-12 17:25:32 UTC

Not just 64bit, altering title.

Comment 4 JP Rosevear 2005-09-12 18:03:56 UTC

Not RML's patch, causing the problem.

Comment 5 Federico Mena Quintero 2005-09-12 19:42:25 UTC

I can duplicate this with the same stack trace as comment #2.

Our patch for submount calls gnome_vfs_volume_get_filesystem_type() and passes
the result to strcmp().  The file system type will be null in the case of audio
CDs, which are nevertheless listed as mounted (per gnome-vfs-hal-mounts.c:976).

Comment 6 Federico Mena Quintero 2005-09-12 20:02:16 UTC

Created attachment 49678 [details]
Updated gnome-vfs-submount.patch

I'll use this updated patch.  Our submount patch didn't take into account that
the file system type will be null for certain types of volumes.  I'll submit
this to autobuild in a second.

Comment 7 Federico Mena Quintero 2005-09-12 20:32:44 UTC

Stanislav made an unrelated change to gnome-vfs2, so it's sitting in autobuild.
 I'll try to re-submit this later.

Comment 8 Federico Mena Quintero 2005-09-12 20:40:09 UTC

Submitted to autobuild.  The fix will appear in gnome-vfs2-2.12.0-8 or later.

Comment 12 OBSbugzilla Bot 2020-12-08 09:30:07 UTC

This is an autogenerated message for OBS integration:
This bug (116558) was mentioned in
https://build.opensuse.org/request/show/853733 Factory / cryptsetup