Bug 117193

Summary:	luit sometimes hangs
Product:	[openSUSE] SUSE LINUX 10.0	Reporter:	Mike Fabian <mfabian>
Component:	X11 Applications	Assignee:	Stefan Dirsch <sndirsch>
Status:	RESOLVED FIXED	QA Contact:	Stefan Dirsch <sndirsch>
Severity:	Normal
Priority:	P2 - High	CC:	jch, ma, mined, sndirsch, towo, werner
Version:	RC 4
Target Milestone:	---
Hardware:	Other
OS:	All
Whiteboard:
Found By:	Development	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Attachments:	strace of hanging 'luit -x mutt' p_bugzilla-117193-luit-sometimes-hangs.diff

Description Mike Fabian 2005-09-15 10:42:03 UTC

Bug found by Michael Andres:

luit sometimes hangs. Example:

mfabian@rossini:~$ for i in 1 2 3 4 5 6 7 8 9 0 ; do echo $i; luit -x echo; done
1

2

[... hangs here ...]

Comment 1 Michael Andres 2005-09-15 10:50:57 UTC

Created attachment 50010 [details]
strace of hanging 'luit -x mutt'

Comment 2 Mike Fabian 2005-09-28 15:42:26 UTC

Created attachment 51058 [details]
p_bugzilla-117193-luit-sometimes-hangs.diff

Patch which seems to solve the problem for me.

Comment 3 Mike Fabian 2005-09-28 15:46:25 UTC

If I understand it right, pty setup stuff like

    copyTermios(0, pty);

should be called *before* forking, otherwise the program
started in the child part with "execvp()" may already
try to write on the pty before the setup is finished.

I'm not sure about the signal-handlers. But probably
it cannot hurt to do this before the for as well.

Comment 4 Juliusz Chroboczek 2005-09-28 18:18:26 UTC

Looks fine to me.

Comment 5 Stefan Dirsch 2005-09-28 19:56:52 UTC

fixed for 10.1 Alpha2.