Bug 117642

Summary: YaST does not correctly quote arguments in /etc/lilo.conf
Product: [openSUSE] SUSE LINUX 10.0 Reporter: Björn Voigt <bjoernv>
Component: YaST2Assignee: Jiri Srain <jsrain>
Status: VERIFIED FIXED QA Contact: Klaus Kämpf <kkaempf>
Severity: Major    
Priority: P5 - None CC: Ulrich.Windl
Version: RC 1   
Target Milestone: ---   
Hardware: PC   
OS: All   
Whiteboard:
Found By: Other Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description Björn Voigt 2005-09-17 18:59:29 UTC
I have an existing /etc/lilo.conf with the following section

image = /boot/vmlinuz-2.4.31
    label = linux2431
    root = /dev/hdb6
    vga = 791
    append = "hdc=scsi"

Now I change some the lilo.conf with YaST:

System->Boot Loader->Section Management ... no changes .. Finish
YaST reports an error and asks me, if I like to retry.

If I start lilo manually after YaST, I see the following error:

$ lilo
Added suse93
Added linux26131 *
Syntax error at or above line 36 in file '/etc/lilo.conf'

The reason for this error is, that YaST changed the line 

    append = "hdc=scsi"

to 

    append = hdc=scsi

Generally spoken, YaST does not use correct quotings for such kind of arguments.
Comment 1 Jiri Srain 2005-09-27 08:46:16 UTC
I fixed it for 10.1. 
 
Andreas, I suggest we should fix it for 10.0 as well. Do you agree? 
Comment 2 Andreas Jaeger 2005-09-27 09:01:40 UTC
Since this happens during installation, we cannot change this anymore.
Comment 3 Jiri Srain 2005-09-27 09:09:40 UTC
That's right, but the bug occurres in installed system as well (if such 
parameter is added later). 
Comment 4 Andreas Jaeger 2005-09-27 11:45:01 UTC
Ah, ok: Maintenance-Tracker-2393

Btw. please open a new bug against the release notes and document this under
section "Update problems"!
Comment 5 Jiri Srain 2005-09-29 10:55:17 UTC
Submitted including the patchinfo, bug 119406 was opened for the releaase 
notes. 
Comment 6 Jiri Srain 2005-10-12 09:13:06 UTC
*** Bug 121981 has been marked as a duplicate of this bug. ***
Comment 7 Anja Stock 2005-10-17 12:47:54 UTC
released