Bug 1180468

Summary:	yast2 security throws Internal Error
Product:	[openSUSE] openSUSE Distribution	Reporter:	Pi Ny <piny>
Component:	YaST2	Assignee:	YaST Team <yast-internal>
Status:	CONFIRMED ---	QA Contact:	Jiri Srain <jsrain>
Severity:	Normal
Priority:	P2 - High	CC:	dgonzalez, jreidinger, piny
Version:	Leap 15.2
Target Milestone:	---
Hardware:	Other
OS:	openSUSE Leap 15.2
URL:	https://trello.com/c/nMMKt1jS
Whiteboard:
Found By:	---	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Attachments:	created by save_y2logs

Description Pi Ny 2020-12-30 23:34:12 UTC

yast2 security throws Internal Error

Module take a while to load, window is "empty", then following
Err-Message window appears

```
Internal error. Please report a bug report with logs.
Run save_y2logs to get complete logs.

Caller: /usr/share/YaST2/lib/yast2/target_file.rb:34:in `read'

Details: Is a directory @ io_fread - /usr/local/lib/sysctl.d/src
```

so

```
# save_y2logs 
Saving YaST logs to /tmp/y2log-nuFCCs.tar.xz
```

y2log-nuFCCs.tar.xz attached.


Hmm, attachment not possible, Browser displays following message

```
Software error:

Malformed multipart POST: data truncated

For help, please send mail to the webmaster (novbugzilla-dev@forge.provo.novell.com), giving this error message and the time and date of the error. 
```
(I don't assume you want me to send an email to Novell, do you?)

Thu Dec 31 00:33:42 CET 2020

Comment 1 Pi Ny 2020-12-30 23:42:13 UTC

Upload also as separate comment not possibler - same error message..

Comment 2 David Diaz 2020-12-31 09:24:45 UTC

Hi Pi Ny, 

Could you please try to upload logs again? Please, check if your problem is related to https://en.opensuse.org/openSUSE:Report_a_YaST_bug#Firefox_fails_to_attach_the_.2Ftmp.2Fy2logs-.2A.tar.gz_that_I_saved_with_save_y2logs._Why.3F

Thanks!

Comment 3 Josef Reidinger 2020-12-31 09:27:27 UTC

Thanks for report. Issue is that our code does not expect directory in directory

https://github.com/yast/yast-yast2/blob/1629c3a520ebd8e8b93f1161f06d9e140d65b9ec/library/general/src/lib/cfa/sysctl_config.rb#L160

Comment 4 Pi Ny 2020-12-31 11:48:41 UTC

Created attachment 844762 [details]
created by save_y2logs

Comment 5 Pi Ny 2020-12-31 11:49:49 UTC

(In reply to David Diaz from comment #2)
> Hi Pi Ny, 
> 
> Could you please try to upload logs again? Please, check if your problem is
> related to
> https://en.opensuse.org/openSUSE:
> Report_a_YaST_bug#Firefox_fails_to_attach_the_.2Ftmp.2Fy2logs-.2A.tar.
> gz_that_I_saved_with_save_y2logs._Why.3F
> 
> Thanks!

Thanks for pointing me to that st*** detail - fixed it and upload works...

Comment 6 Pi Ny 2020-12-31 11:51:13 UTC

(In reply to Pi Ny from comment #1)
> Upload also as separate comment not possibler - same error message..

Fixed w/ https://bugzilla.opensuse.org/show_bug.cgi?id=1180468#c4

Comment 7 Pi Ny 2020-12-31 11:57:27 UTC

(In reply to Josef Reidinger from comment #3)
> Thanks for report. Issue is that our code does not expect directory in
> directory
> 
> https://github.com/yast/yast-yast2/blob/
> 1629c3a520ebd8e8b93f1161f06d9e140d65b9ec/library/general/src/lib/cfa/
> sysctl_config.rb#L160

I maintain my "local" stuff in a directory at /usr/local/lib/sysctl.d/src/ in order to survive upgrades etc.
However, since /usr/local/lib is not available at boot time actually all relevant files are copied to /etc/sysctl.d.

-> should the code ignore /usr/local/lib completely?

Comment 8 Pi Ny 2020-12-31 12:07:50 UTC

(In reply to Pi Ny from comment #7)
> (In reply to Josef Reidinger from comment #3)
> > Thanks for report. Issue is that our code does not expect directory in
> > directory
> > 
> > https://github.com/yast/yast-yast2/blob/
> > 1629c3a520ebd8e8b93f1161f06d9e140d65b9ec/library/general/src/lib/cfa/
> > sysctl_config.rb#L160
> 
> I maintain my "local" stuff in a directory at /usr/local/lib/sysctl.d/src/
> in order to survive upgrades etc.
> However, since /usr/local/lib is not available at boot time actually all
> relevant files are copied to /etc/sysctl.d.
> 
> -> should the code ignore /usr/local/lib completely?

Changed the name of the sub-directory to /usr/local/lib/_sysctl.d_/

-> now yast2 security shows up w/o error!