Bug 1181870

Summary: GCC 11: liblastfm-qt5 package fails
Product: [openSUSE] openSUSE Tumbleweed Reporter: Martin Liška <martin.liska>
Component: BasesystemAssignee: Christophe Marin <christophe>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None CC: christophe
Version: Current   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Bug Depends on:    
Bug Blocks: 1181859    

Description Martin Liška 2021-02-06 11:11:09 UTC 
Fails here:
https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:Gcc7/liblastfm-qt5/standard/x86_64

with:
[   38s] /home/abuild/rpmbuild/BUILD/liblastfm-1.0.9+20150206/src/fingerprint/Fingerprint.h:74:49: error: ISO C++17 does not allow dynamic exception specifications
[   38s]    74 |         void generate( FingerprintableSource* ) throw( Error );
[   38s]       |                                                 ^~~~~
[   38s] /home/abuild/rpmbuild/BUILD/liblastfm-1.0.9+20150206/src/fingerprint/Fingerprint.h:85:86: error: ISO C++17 does not allow dynamic exception specifications
[   38s]    85 |         void decode( QNetworkReply*, bool* lastfm_needs_a_complete_fingerprint = 0 ) throw( Error );
[   38s]       |                                                                                      ^~~~~
[   38s] /home/abuild/rpmbuild/BUILD/liblastfm-1.0.9+20150206/src/fingerprint/Collection.cpp: In member function 'bool Collection::query(const QString&)':
[   38s] /home/abuild/rpmbuild/BUILD/liblastfm-1.0.9+20150206/src/fingerprint/Collection.cpp:202:65: warning: 'QTextStream& QTextStreamFunctions::endl(QTextStream&)' is deprecated: Use Qt::endl [-Wdeprecated-declarations]
[   38s]   202 |         qDebug() << "SQL query failed:" << query.lastQuery() << endl
Comment 1 Christophe Marin 2021-02-08 12:07:39 UTC 
What's the recommended fix? drop the `throw( Error )` lines or sticking to an older standard?

The project is dead upstream
Comment 2 Martin Liška 2021-02-08 18:29:48 UTC 
(In reply to Christophe Giboudeaux from comment #1)
> What's the recommended fix? drop the `throw( Error )` lines or sticking to
> an older standard?
> 
> The project is dead upstream

I think both approaches are feasible, use the easier for your.
Thanks.
Comment 3 Christophe Marin 2021-02-09 15:01:30 UTC 
https://build.opensuse.org/request/show/870475
Comment 4 Christophe Marin 2021-02-16 08:43:30 UTC 
fixed in factory