|
Bugzilla – Full Text Bug Listing |
| Summary: | GCC 11: fcoe-utils package fails | ||
|---|---|---|---|
| Product: | [openSUSE] openSUSE Tumbleweed | Reporter: | Martin Liška <martin.liska> |
| Component: | Basesystem | Assignee: | Lee Duncan <lduncan> |
| Status: | RESOLVED FIXED | QA Contact: | E-mail List <qa-bugs> |
| Severity: | Normal | ||
| Priority: | P5 - None | ||
| Version: | Current | ||
| Target Milestone: | --- | ||
| Hardware: | Other | ||
| OS: | Other | ||
| Whiteboard: | |||
| Found By: | --- | Services Priority: | |
| Business Priority: | Blocker: | --- | |
| Marketing QA Status: | --- | IT Deployment: | --- |
| Bug Depends on: | |||
| Bug Blocks: | 1181859 | ||
| Attachments: |
possible fix for compiler issues
Test patch (not yet upstream) to make gcc-11 happy |
||
|
Description
Martin Liška
2021-02-26 13:56:42 UTC
May I please ping this? Lee, can you have a look? Some of this is nasty ... :( Created attachment 847477 [details]
possible fix for compiler issues
Not sure why the compiler doesn't like some of this stuff (I tried to figure it out but could not), but this diff makes the compiler happy and hopefully does not change any functionality.
(In reply to Lee Duncan from comment #4) > Created attachment 847477 [details] > possible fix for compiler issues > > Not sure why the compiler doesn't like some of this stuff (I tried to figure > it out but could not), but this diff makes the compiler happy and hopefully > does not change any functionality. From a quick look, it seems the compiler complains correctly. You copy memory to (or from) a location which storage is smaller than the request length. Note that there may be padding in between the fields for instance. You can likely cast to (char *) and do the copying, it should silent the warning. Working upstream, at github.com://openSUSE/fcoe-utils, and my clone of that. I will attach the latest suggested fix. Created attachment 847561 [details]
Test patch (not yet upstream) to make gcc-11 happy
Feel free to comment on this patch. Manually compiling with gcc-11 fails before this patch and passes after it.
This commit is still being discussed upstream but seems likely to be the final version.
(In reply to Martin Liška from comment #5) > (In reply to Lee Duncan from comment #4) > > Created attachment 847477 [details] > > possible fix for compiler issues > > > > Not sure why the compiler doesn't like some of this stuff (I tried to figure > > it out but could not), but this diff makes the compiler happy and hopefully > > does not change any functionality. > > From a quick look, it seems the compiler complains correctly. You copy > memory to (or from) a location which storage is smaller than the request > length. Note that there may be padding in between the fields for instance. > You can likely cast to (char *) and do the copying, it should silent the > warning. A cast to uint32_t* worked. Thanks. Changes committed upstream, new version tagged, and now updating Factory. Thanks, fixed in devel project. SUSE-RU-2021:3390-1: An update that has two recommended fixes can now be installed. Category: recommended (moderate) Bug References: 1010047,1182804 CVE References: JIRA References: Sources used: SUSE MicroOS 5.1 (src): fcoe-utils-1.0.34-12.3.1 SUSE Linux Enterprise Module for Basesystem 15-SP3 (src): fcoe-utils-1.0.34-12.3.1 NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination. openSUSE-RU-2021:3390-1: An update that has two recommended fixes can now be installed. Category: recommended (moderate) Bug References: 1010047,1182804 CVE References: JIRA References: Sources used: openSUSE Leap 15.3 (src): fcoe-utils-1.0.34-12.3.1 |