Bug 1185103

Summary: GCC 11: open-vm-tools package fails
Product: [openSUSE] openSUSE Tumbleweed Reporter: Martin Liška <martin.liska>
Component: BasesystemAssignee: Kirk Allan <kallan>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None CC: kallan
Version: Current   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Bug Depends on:    
Bug Blocks: 1181859    

Description Martin Liška 2021-04-21 14:51:28 UTC
Fails here:
https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:Gcc7/open-vm-tools/standard/x86_64

due to:
[   80s] In file included from /usr/include/glib-2.0/glib/gthread.h:32,
[   80s]                  from /usr/include/glib-2.0/glib/gasyncqueue.h:32,
[   80s]                  from /usr/include/glib-2.0/glib.h:32,
[   80s]                  from pollGtk.c:53:
[   80s] pollGtk.c: In function 'Poll_InitGtk':
[   80s] /usr/include/glib-2.0/glib/gatomic.h:117:5: error: argument 2 of '__atomic_load' discards 'volatile' qualifier [-Werror=incompatible-pointer-types]
[   80s]   117 |     __atomic_load (gapg_temp_atomic, &gapg_temp_newval, __ATOMIC_SEQ_CST); \
[   80s]       |     ^~~~~~~~~~~~~
[   80s] /usr/include/glib-2.0/glib/gthread.h:260:7: note: in expansion of macro 'g_atomic_pointer_get'
[   80s]   260 |     (!g_atomic_pointer_get (location) &&                             \
[   80s]       |       ^~~~~~~~~~~~~~~~~~~~
[   80s] pollGtk.c:1488:8: note: in expansion of macro 'g_once_init_enter'
[   80s]  1488 |    if (g_once_init_enter(&inited)) {
[   80s]       |        ^~~~~~~~~~~~~~~~~


Should be fixed in upstream, one needs to do a backport of:
https://github.com/vmware/open-vm-tools/issues/509
Comment 1 Kirk Allan 2021-05-05 21:18:16 UTC
(In reply to Martin Liška from comment #0)
> Fails here:
> https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:
> Gcc7/open-vm-tools/standard/x86_64
> 
> Should be fixed in upstream, one needs to do a backport of:
> https://github.com/vmware/open-vm-tools/issues/509

Applied the patch mentioned in the 509 commit.  The patch didn't resolve the errors.  I am now working with VMware to get the errors resolved.
Comment 2 Richard Biener 2021-05-06 12:58:12 UTC
May I suggest to add -Wno-error=incompatible-pointer-types to the compile flags in the mean time to unblock GCC 11 from entering Factory?  There are already
a multitude of -Wno-* in the .spec file, adding another one will not hurt.
If you don't just want to disable -Werror for the warning you can disable
the warning with -Wno-incompatible-pointer-types as well.
Comment 3 Kirk Allan 2021-05-06 20:47:35 UTC
(In reply to Richard Biener from comment #2)
> May I suggest to add -Wno-error=incompatible-pointer-types to the compile
> flags in the mean time to unblock GCC 11 from entering Factory?  There are
> already
> a multitude of -Wno-* in the .spec file, adding another one will not hurt.
> If you don't just want to disable -Werror for the warning you can disable
> the warning with -Wno-incompatible-pointer-types as well.

I did try -Wno-incompatible-pointer-types and it worked.  Then I received a patch from VMware that seems to solve the issue so I went with the patch rather than the flag.

The patch has now been submitted to Factory.
Comment 4 Richard Biener 2021-05-07 08:14:57 UTC
Thanks a lot!
Comment 5 Martin Liška 2021-05-10 10:18:10 UTC
Fixed in devel project.
Comment 8 Swamp Workflow Management 2021-07-29 16:27:32 UTC
openSUSE-RU-2021:2568-1: An update that has four recommended fixes can now be installed.

Category: recommended (moderate)
Bug References: 1029961,1185103,1185175,1187567
CVE References: 
JIRA References: 
Sources used:
openSUSE Leap 15.3 (src):    open-vm-tools-11.3.0-10.1
Comment 9 Swamp Workflow Management 2021-07-29 16:29:03 UTC
SUSE-RU-2021:2569-1: An update that has four recommended fixes can now be installed.

Category: recommended (moderate)
Bug References: 1029961,1185103,1185175,1187567
CVE References: 
JIRA References: 
Sources used:
SUSE OpenStack Cloud Crowbar 9 (src):    open-vm-tools-11.3.0-4.36.1
SUSE OpenStack Cloud 9 (src):    open-vm-tools-11.3.0-4.36.1
SUSE Linux Enterprise Server for SAP 12-SP4 (src):    open-vm-tools-11.3.0-4.36.1
SUSE Linux Enterprise Server 12-SP5 (src):    open-vm-tools-11.3.0-4.36.1
SUSE Linux Enterprise Server 12-SP4-LTSS (src):    open-vm-tools-11.3.0-4.36.1

NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination.
Comment 10 Swamp Workflow Management 2021-07-29 16:32:03 UTC
SUSE-RU-2021:2568-1: An update that has four recommended fixes can now be installed.

Category: recommended (moderate)
Bug References: 1029961,1185103,1185175,1187567
CVE References: 
JIRA References: 
Sources used:
SUSE Linux Enterprise Module for Desktop Applications 15-SP3 (src):    open-vm-tools-11.3.0-10.1
SUSE Linux Enterprise Module for Basesystem 15-SP3 (src):    open-vm-tools-11.3.0-10.1

NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination.
Comment 11 Swamp Workflow Management 2021-07-29 16:33:32 UTC
SUSE-RU-2021:2571-1: An update that has four recommended fixes can now be installed.

Category: recommended (moderate)
Bug References: 1029961,1185103,1185175,1187567
CVE References: 
JIRA References: 
Sources used:
SUSE MicroOS 5.0 (src):    open-vm-tools-11.3.0-5.16.4.1
SUSE Linux Enterprise Module for Desktop Applications 15-SP2 (src):    open-vm-tools-11.3.0-5.16.4.1
SUSE Linux Enterprise Module for Basesystem 15-SP2 (src):    open-vm-tools-11.3.0-5.16.4.1

NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination.
Comment 12 Swamp Workflow Management 2021-08-05 13:49:39 UTC
SUSE-RU-2021:2628-1: An update that has 5 recommended fixes can now be installed.

Category: recommended (moderate)
Bug References: 1029961,1180997,1185103,1185175,1187567
CVE References: 
JIRA References: 
Sources used:
SUSE Manager Server 4.0 (src):    open-vm-tools-11.3.0-4.37.7.1
SUSE Manager Retail Branch Server 4.0 (src):    open-vm-tools-11.3.0-4.37.7.1
SUSE Manager Proxy 4.0 (src):    open-vm-tools-11.3.0-4.37.7.1
SUSE Linux Enterprise Server for SAP 15-SP1 (src):    open-vm-tools-11.3.0-4.37.7.1
SUSE Linux Enterprise Server 15-SP1-LTSS (src):    open-vm-tools-11.3.0-4.37.7.1
SUSE Linux Enterprise Server 15-SP1-BCL (src):    open-vm-tools-11.3.0-4.37.7.1
SUSE Linux Enterprise High Performance Computing 15-SP1-LTSS (src):    open-vm-tools-11.3.0-4.37.7.1
SUSE Linux Enterprise High Performance Computing 15-SP1-ESPOS (src):    open-vm-tools-11.3.0-4.37.7.1
SUSE Enterprise Storage 6 (src):    open-vm-tools-11.3.0-4.37.7.1
SUSE CaaS Platform 4.0 (src):    open-vm-tools-11.3.0-4.37.7.1

NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination.
Comment 13 Swamp Workflow Management 2021-08-10 07:24:11 UTC
openSUSE-RU-2021:1128-1: An update that has 5 recommended fixes can now be installed.

Category: recommended (moderate)
Bug References: 1029961,1180997,1185103,1185175,1187567
CVE References: 
JIRA References: 
Sources used:
openSUSE Leap 15.2 (src):    open-vm-tools-11.3.0-lp152.3.12.1