|
Bugzilla – Full Text Bug Listing |
| Summary: | yast2-* packages should not own /usr/share/icons directory structure | ||
|---|---|---|---|
| Product: | [openSUSE] openSUSE Tumbleweed | Reporter: | Dominique Leuenberger <dimstar> |
| Component: | YaST2 | Assignee: | Ladislav Slezák <lslezak> |
| Status: | IN_PROGRESS --- | QA Contact: | Jiri Srain <jsrain> |
| Severity: | Normal | ||
| Priority: | P3 - Medium | CC: | dleuenberger, jengelh, opensuse.lietuviu.kalba |
| Version: | Current | ||
| Target Milestone: | --- | ||
| Hardware: | Other | ||
| OS: | Other | ||
| Whiteboard: | |||
| Found By: | --- | Services Priority: | |
| Business Priority: | Blocker: | --- | |
| Marketing QA Status: | --- | IT Deployment: | --- |
|
Description
Dominique Leuenberger
2021-05-14 14:43:34 UTC
To be honest I do not like much changing the %yast_icondir to /usr/share/icons/hicolor/*/*/*.svg, all %yast_*dir macros point to some directory, that's why they use the "dir" suffix. (https://github.com/yast/yast-devtools/blob/817d8a7462bfcf19ccba0c2463bd81ed4c0a903f/build-tools/rpm/macros.yast#L5-L32) Having one different macro which uses files looks like a hack, I'd rather avoid that. The filesystem package now owns /usr/share/icons, but not /usr/share/icons/hicolor. And all YaST icons are located in the "hicolor" subdirectory. So what about simply changing it from /usr/share/icons to /usr/share/icons/hicolor? Another option would be to change all %{yast_icondir} lines to %{yast_icondir}/*/*/*/*.svg The drawback is that this would require to touch 79 spec files... :-( (In reply to Ladislav Slezák from comment #1) > So what about simply changing it from /usr/share/icons to > /usr/share/icons/hicolor? That should work. then you just move the problem one directory higher - if that ever changes mode, we're at the same point I'm not (yet) sure if the hicolor-icon-theme is supposedto be adjusted too, but chances are it will be but I do see the problem with the macro being called *_dir, and then it is files so in short: it's acceptable, but might require to come back to it later again Why even change mode of /usr/share/icons to 555? What does that buy? (In reply to Thorsten Kukuk from comment #2) > (In reply to Ladislav Slezák from comment #1) > > > So what about simply changing it from /usr/share/icons to > > /usr/share/icons/hicolor? > > That should work. openSUSE Leap and TW has also option to install ANOTHER theme than default hicolor, thus forcing /usr/share/icons/hicolor is not solution Maybe better set directory via update-alternatives / YasST Alternatives? See also https://software.opensuse.org/search?utf8=%E2%9C%93&baseproject=ALL&q=yast2-theme https://software.opensuse.org/package/yast2-theme-oxygen https://software.opensuse.org/package/yast2-theme-breeze Though even update-altertives is not option, because we can install yast2-theme-breeze and yast2-theme-oxygen and other themes simultaneously and actual theme depends on desktop icon theme of (root) user! (In reply to Mindaugas Baranauskas from comment #17) > (In reply to Thorsten Kukuk from comment #2) > > (In reply to Ladislav Slezák from comment #1) > > > > > So what about simply changing it from /usr/share/icons to > > > /usr/share/icons/hicolor? > > > > That should work. > > openSUSE Leap and TW has also option to install ANOTHER theme than default > hicolor, thus forcing /usr/share/icons/hicolor is not solution > Maybe better set directory via update-alternatives / YasST Alternatives? > > See also > https://software.opensuse.org/search?utf8=%E2%9C%93&baseproject=ALL&q=yast2- > theme > https://software.opensuse.org/package/yast2-theme-oxygen > https://software.opensuse.org/package/yast2-theme-breeze Those packages can still install different themes, just not rely on yast2_icondir; no harm done. |