Bug 1200581

Summary: No openSUSE Leap logo in GNOME Settings
Product: [openSUSE] openSUSE Distribution Reporter: Ivan Vorstanenko <ivanvorstanenko>
Component: GNOMEAssignee: E-mail List <gnome-bugs>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None CC: alynx.zhou, milachew, pdostal, xiaoguang.wang
Version: Leap 15.5   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: Output of command
Changes

Description Ivan Vorstanenko 2022-06-15 19:06:40 UTC
Created attachment 859633 [details]
Output of command

There is no openSUSE Leap log in Settings.

All distribution-logos* packages installed.
Comment 1 Ivan Vorstanenko 2022-06-16 08:45:34 UTC
Also, I tried to force set icon. But, without result - no icon was added.

> ivan@homepc:~> G_RESOURCE_OVERLAYS='/org/gnome/control-center/info=/home/ivan/square-hicolor.svg' gnome-control-center
> GLib-GIO-Message: 11:36:55.161: Adding GResources overlay '/org/gnome/control-center/info=/home/ivan/square-hicolor.svg'

Also, deleting ditribution-logos*, logo changes to "Exclamation point" in About System.
I think, problem not in icons on system but in gnome-control-settings.
Comment 2 Milachew 2022-09-29 18:29:11 UTC
I tried to find the problem component of that...

When I try to delete icon from /usr/share/hicolor/scalable/distributor-logo-Leap.svg, logo in GNOME Settings change to "Exclamation point".

But no matter what icon I replace of there, it still doesn't appear.

Or rather, it is there. If I switch to a dark theme, I see a small white dot instead of an icon.

So, problem not in icons, that's for sure.
I think, problem in gnome-control-center... but it is only hypothesis.
Comment 3 Milachew 2022-10-18 09:38:49 UTC
Fix in https://build.opensuse.org/request/show/1029693
Comment 4 Milachew 2022-10-18 09:39:39 UTC
Created attachment 862240 [details]
Changes
Comment 5 xiaoguang wang 2022-10-20 04:56:41 UTC
I'm reviewing the request https://build.suse.de/request/show/282777, I'm not sure whether it's the right way to fix the issue.
I did some test, I moved /usr/share/icons/hicolor/scalable/apps/distributor-logo-Leap.svg to /usr/share/icons/hicolor/128x128/apps/, and did gtk-update-icon-cache /usr/share/icons/hicolor, then the logo is shown.

Also can reference this bug https://bugzilla.suse.com/show_bug.cgi?id=1192669
Comment 6 Milachew 2022-10-20 09:34:07 UTC
(In reply to xiaoguang wang from comment #5)
> I'm not sure whether it's the right way to fix the issue.
> I did some test, I moved
> /usr/share/icons/hicolor/scalable/apps/distributor-logo-Leap.svg to
> /usr/share/icons/hicolor/128x128/apps/, and did gtk-update-icon-cache
> /usr/share/icons/hicolor, then the logo is shown.

So, if we consider this way, then it is necessary to move, not copy the icon.
Otherwise it doesn't work, I checked.
Also, it is enough to unpack the desired icon (with "Leap") into the 128x128 folder.
I similarly suggested "distributor-logo.svg" to unpack in 128x128, so that there would be no discrepancy (correct, if this does not need to be done, I will correct the proposal).

And... can this affect other applications that expect an icon in the "scalable" folder?
- if they don't break, then I have already suggested a change (1)
- if they can break, then I suggest adding the patch and than I will revoke proposed change above.

> Also can reference this bug https://bugzilla.suse.com/show_bug.cgi?id=1192669

Yes, the bug is very similar, thank you!
This bug report refers to the same upstream commits, which is why I decided to write just such a patch (it is small, affects only one problematic component and should not conflict with others).

----------
1. https://build.opensuse.org/request/show/1030129
Comment 7 xiaoguang wang 2022-10-21 02:34:36 UTC
(In reply to Milachew from comment #6) 
> So, if we consider this way, then it is necessary to move, not copy the icon.
> Otherwise it doesn't work, I checked.
Yes, you are right. We need to delete logo file in scalable folder, but we don't know whether it will affect other applications.
For now it's seem the patch is the simplest way to fix the issue, so I decide to  accept the request.
Thank you.
Comment 9 Milachew 2022-10-21 08:37:20 UTC
(In reply to xiaoguang wang from comment #7)
> For now it's seem the patch is the simplest way to fix the issue, so I
> decide to  accept the request.
> Thank you.

Good!
Do I understand correctly that there is no need to create a request with this patch for Leap 15.5/SLE 15 SP5, because they will receive this fix after a while, along with GNOME 41.7?
Comment 10 xiaoguang wang 2022-10-21 08:52:11 UTC
(In reply to Milachew from comment #9)
> Do I understand correctly that there is no need to create a request with
> this patch for Leap 15.5/SLE 15 SP5, because they will receive this fix
> after a while, along with GNOME 41.7?
Yes, needn't to send request to Leap 15.5. Leap 15.5 should inherit Leap 15.4.
Comment 11 Milachew 2022-10-21 09:12:52 UTC
(In reply to xiaoguang wang from comment #10)
> Yes, needn't to send request to Leap 15.5. Leap 15.5 should inherit Leap
> 15.4.
Understand.

So, there is a fix, it has been tested and works, it will get into 15.5.
Then I close this bug report.

Thank you, Xiaoguang Wang and you, Ivan!
Comment 13 Alynx Zhou 2022-10-25 04:03:57 UTC
If our logo is a square, this workaround is acceptable. This is a complex GTK3 bug that it will choose 1px as size if not set for icon in `hicolor` so user cannot see the icon. In tumbleweed this is fixed when gnome-control-center upgrades to GTK4.
Comment 14 Milachew 2022-10-25 15:19:14 UTC
(In reply to Alynx Zhou from comment #13)
> If our logo is a square, this workaround is acceptable. This is a complex
> GTK3 bug that it will choose 1px as size if not set for icon in `hicolor` so
> user cannot see the icon. In tumbleweed this is fixed when
> gnome-control-center upgrades to GTK4.

Thanks for the clarification!
Fortunately, this has been fixed in a workaround.
Comment 15 Swamp Workflow Management 2022-12-21 17:21:26 UTC
SUSE-FU-2022:4601-1: An update that has 8 feature fixes and contains one feature can now be installed.

Category: feature (moderate)
Bug References: 1175622,1179584,1188882,1196205,1200581,1203274,1204867,944832
CVE References: 
JIRA References: PED-2235
Sources used:
openSUSE Leap Micro 5.3 (src):    glib2-2.70.5-150400.3.3.1, librsvg-2.52.9-150400.3.3.1, python-gobject-3.42.2-150400.3.3.2
openSUSE Leap 15.4 (src):    atkmm1_6-2.28.3-150400.4.3.1, eog-41.2-150400.3.3.2, evince-41.4-150400.3.3.3, evolution-3.42.4-150400.3.3.1, evolution-data-server-3.42.5-150400.3.3.2, folks-0.15.5-150400.5.3.2, gcr-3.41.1-150400.3.3.1, geocode-glib-3.26.4-150400.3.3.2, gjs-1.70.2-150400.3.3.1, glib2-2.70.5-150400.3.3.1, glib2-branding-SLE-15-150400.27.2.1, gnome-control-center-41.7-150400.3.3.1, gnome-desktop-41.8-150400.3.3.1, gnome-music-41.1-150400.3.3.1, gnome-remote-desktop-41.3-150400.3.3.1, gnome-session-41.3-150400.3.3.1, gnome-shell-41.9-150400.3.3.2, gnome-software-41.5-150400.3.3.2, gnome-terminal-3.42.3-150400.3.3.1, gnome-user-docs-41.5-150400.3.3.1, gspell-1.10.0-150400.3.3.1, gtk-vnc-1.3.1-150400.3.3.1, gtkmm3-3.24.6-150400.3.3.1, gupnp-av-0.14.1-150400.7.3.1, gvfs-1.48.2-150400.4.6.1, libgsf-1.14.50-150400.3.3.1, libmediaart-1.9.6-150400.3.3.1, libnma-1.8.40-150400.3.3.1, libnotify-0.7.12-150400.3.3.1, libpeas-1.32.0-150400.4.3.2, librsvg-2.52.9-150400.3.3.1, libsecret-0.20.5-150400.4.3.1, mutter-41.9-150400.3.6.1, nautilus-41.5-150400.3.3.1, orca-41.3-150400.3.3.1, python-cairo-1.15.1-150000.3.6.1, python-gobject-3.42.2-150400.3.3.2, tracker-miners-3.2.2-150400.3.3.1, vala-0.54.8-150400.3.3.1, xdg-desktop-portal-gnome-41.2-150400.3.3.1
openSUSE Leap 15.3 (src):    python-cairo-1.15.1-150000.3.6.1
SUSE Linux Enterprise Workstation Extension 15-SP4 (src):    evolution-3.42.4-150400.3.3.1, evolution-data-server-3.42.5-150400.3.3.2, folks-0.15.5-150400.5.3.2, gnome-control-center-41.7-150400.3.3.1, gnome-music-41.1-150400.3.3.1, gnome-remote-desktop-41.3-150400.3.3.1, gnome-session-41.3-150400.3.3.1, gnome-shell-41.9-150400.3.3.2, libgsf-1.14.50-150400.3.3.1, libmediaart-1.9.6-150400.3.3.1, libnma-1.8.40-150400.3.3.1, tracker-miners-3.2.2-150400.3.3.1
SUSE Linux Enterprise Module for Server Applications 15-SP4 (src):    gtk-vnc-1.3.1-150400.3.3.1
SUSE Linux Enterprise Module for Python2 15-SP3 (src):    python-cairo-1.15.1-150000.3.6.1
SUSE Linux Enterprise Module for Packagehub Subpackages 15-SP4 (src):    evolution-3.42.4-150400.3.3.1, evolution-data-server-3.42.5-150400.3.3.2, folks-0.15.5-150400.5.3.2, gnome-music-41.1-150400.3.3.1, gnome-remote-desktop-41.3-150400.3.3.1, gtkmm3-3.24.6-150400.3.3.1, libmediaart-1.9.6-150400.3.3.1, python-cairo-1.15.1-150000.3.6.1
SUSE Linux Enterprise Module for Packagehub Subpackages 15-SP3 (src):    python-cairo-1.15.1-150000.3.6.1
SUSE Linux Enterprise Module for Development Tools 15-SP4 (src):    libpeas-1.32.0-150400.4.3.2, vala-0.54.8-150400.3.3.1
SUSE Linux Enterprise Module for Desktop Applications 15-SP4 (src):    atkmm1_6-2.28.3-150400.4.3.1, eog-41.2-150400.3.3.2, evince-41.4-150400.3.3.3, gcr-3.41.1-150400.3.3.1, geocode-glib-3.26.4-150400.3.3.2, gjs-1.70.2-150400.3.3.1, gnome-control-center-41.7-150400.3.3.1, gnome-desktop-41.8-150400.3.3.1, gnome-session-41.3-150400.3.3.1, gnome-shell-41.9-150400.3.3.2, gnome-software-41.5-150400.3.3.2, gnome-terminal-3.42.3-150400.3.3.1, gnome-user-docs-41.5-150400.3.3.1, gspell-1.10.0-150400.3.3.1, gtkmm3-3.24.6-150400.3.3.1, gvfs-1.48.2-150400.4.6.1, libgsf-1.14.50-150400.3.3.1, libnma-1.8.40-150400.3.3.1, libnotify-0.7.12-150400.3.3.1, libpeas-1.32.0-150400.4.3.2, librsvg-2.52.9-150400.3.3.1, mutter-41.9-150400.3.6.1, nautilus-41.5-150400.3.3.1, orca-41.3-150400.3.3.1, python-cairo-1.15.1-150000.3.6.1, tracker-miners-3.2.2-150400.3.3.1, xdg-desktop-portal-gnome-41.2-150400.3.3.1
SUSE Linux Enterprise Module for Desktop Applications 15-SP3 (src):    python-cairo-1.15.1-150000.3.6.1
SUSE Linux Enterprise Module for Basesystem 15-SP4 (src):    glib2-2.70.5-150400.3.3.1, glib2-branding-SLE-15-150400.27.2.1, gtk-vnc-1.3.1-150400.3.3.1, libnotify-0.7.12-150400.3.3.1, librsvg-2.52.9-150400.3.3.1, libsecret-0.20.5-150400.4.3.1, python-cairo-1.15.1-150000.3.6.1, python-gobject-3.42.2-150400.3.3.2
SUSE Linux Enterprise Module for Basesystem 15-SP3 (src):    python-cairo-1.15.1-150000.3.6.1
SUSE Linux Enterprise Micro 5.3 (src):    glib2-2.70.5-150400.3.3.1, glib2-branding-SLE-15-150400.27.2.1, librsvg-2.52.9-150400.3.3.1, python-cairo-1.15.1-150000.3.6.1, python-gobject-3.42.2-150400.3.3.2

NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination.
Comment 17 Maintenance Automation 2023-07-27 08:55:41 UTC
SUSE-RU-2023:2996-1: An update that has two recommended fixes can now be installed.

Category: recommended (important)
Bug References: 1200581, 1213115
Sources used:
openSUSE Leap 15.5 (src): gnome-control-center-41.7-150500.3.3.1
Desktop Applications Module 15-SP5 (src): gnome-control-center-41.7-150500.3.3.1
SUSE Linux Enterprise Workstation Extension 15 SP5 (src): gnome-control-center-41.7-150500.3.3.1

NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination.