Bug 1212054 (CVE-2023-32682)

Summary: VUL-0: CVE-2023-32682: matrix-synapse: Improper checks for deactivated users during login
Product: [openSUSE] openSUSE Tumbleweed Reporter: Robert Frohl <rfrohl>
Component: SecurityAssignee: Oliver Kurz <okurz>
Status: NEW --- QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P3 - Medium CC: security-team
Version: Current   
Target Milestone: ---   
Hardware: Other   
OS: Other   
URL: https://smash.suse.de/issue/368521/
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description Robert Frohl 2023-06-06 12:09:29 UTC
Impact

It may be possible for a deactivated user to login when using uncommon configurations.

This only applies if any of the following are true:

- JSON Web Tokens are enabled for login via the jwt_config.enabled configuration setting
- The local password database is enabled via the password_config.enabled and password_config.localdb_enabled configuration settings and a user's password is updated via an admin API after a user is deactivated.

Note that the local password database is enabled by default, but it is uncommon to set a user's password after they've been deactivated.

Installations that are configured to only allow login via Single Sign-On (SSO) via CAS, SAML or OpenID Connect (OIDC); or via an external password provider (e.g. LDAP) are not affected.


Patches

- If using JSON Web Token logins: #15624
- For other users: #15634

Workarounds

If not using JSON Web Tokens, ensure that deactivated users do not have a password set. This list of users can be queried from PostgreSQL:

> SELECT name FROM users WHERE password_hash IS NOT NULL AND deactivated = 1;

reference:

https://github.com/matrix-org/synapse/releases/tag/v1.85.0
https://github.com/matrix-org/synapse/security/advisories/GHSA-26c5-ppr8-f33p
Comment 1 OBSbugzilla Bot 2023-07-07 10:35:05 UTC
This is an autogenerated message for OBS integration:
This bug (1212054) was mentioned in
https://build.opensuse.org/request/show/1097110 Factory / matrix-synapse