|
Bugzilla – Full Text Bug Listing |
| Summary: | [TRACKERBUG][aarch64][Lenovo-X13s] Some workaround patches [EFI, sound_clock] for the current kernel support on X13s | ||
|---|---|---|---|
| Product: | [openSUSE] openSUSE Tumbleweed | Reporter: | Chester Lin <chester.lin> |
| Component: | Kernel | Assignee: | Chester Lin <chester.lin> |
| Status: | RESOLVED UPSTREAM | QA Contact: | E-mail List <qa-bugs> |
| Severity: | Normal | ||
| Priority: | P5 - None | CC: | afaerber, dmueller, guillaume.gardet, ivan.ivanov, jlee, jslaby, mbenes, tiwai |
| Version: | Current | ||
| Target Milestone: | --- | ||
| Hardware: | aarch64 | ||
| OS: | Other | ||
| Whiteboard: | |||
| Found By: | --- | Services Priority: | |
| Business Priority: | Blocker: | --- | |
| Marketing QA Status: | --- | IT Deployment: | --- |
|
Description
Chester Lin
2023-09-13 02:28:32 UTC
The following configs need to be enabled for audio support on X13s: CONFIG_SND_SOC_LPASS_WSA_MACRO=m CONFIG_SND_SOC_LPASS_VA_MACRO=m CONFIG_SND_SOC_LPASS_RX_MACRO=m CONFIG_SND_SOC_LPASS_TX_MACRO=m The UEFI firmware of X13s has clk DT overlays that do not match the upstream DT (See as below example). Here we will need a downstream patch in order to enable audio system (LPASS) on X13s.
============
[In FDT overlaid by UEFI]
clock-controller@3300000 {
compatible = "qcom,sc8280xp-lpass-audio-csr";
......
};
clock-controller@33e0000 {
compatible = "qcom,sc8280xp-lpass-tcsr";
......
};
[Upstream DT]
clock-controller@32a9000 {
compatible = "qcom,sc8280xp-lpassaudiocc";
reg = <0x00 0x32a9000 0x00 0x1000>;
#clock-cells = <0x01>;
#reset-cells = <0x01>;
phandle = <0x6f>;
};
clock-controller@33e0000 {
compatible = "qcom,sc8280xp-lpasscc";
reg = <0x00 0x33e0000 0x00 0x12000>;
#clock-cells = <0x01>;
#reset-cells = <0x01>;
phandle = <0x76>;
};
pushed into users/clin/stable/for-next. Waiting for code merge. (In reply to Chester Lin from comment #1) > The following configs need to be enabled for audio support on X13s: > > CONFIG_SND_SOC_LPASS_WSA_MACRO=m > CONFIG_SND_SOC_LPASS_VA_MACRO=m > CONFIG_SND_SOC_LPASS_RX_MACRO=m > CONFIG_SND_SOC_LPASS_TX_MACRO=m Rebased my for-next PR based on Takashi's CONFIG_SND_SOC_LPASS* PR from bsc#1215256. Thanks for Ivan's reminder. (In reply to Chester Lin from comment #2) > The UEFI firmware of X13s has clk DT overlays that do not match the upstream > DT (See as below example). Here we will need a downstream patch in order to > enable audio system (LPASS) on X13s. So how is this going to be handled in upstream? IOW, why do we need a downstream patch and keep upstream broken? (In reply to Jiri Slaby from comment #5) > (In reply to Chester Lin from comment #2) > > The UEFI firmware of X13s has clk DT overlays that do not match the upstream > > DT (See as below example). Here we will need a downstream patch in order to > > enable audio system (LPASS) on X13s. > > So how is this going to be handled in upstream? IOW, why do we need a > downstream patch and keep upstream broken? I think this issue must be fixed in Lenovo UEFI firmware since Lenovo should follow the upstream dt-bindings (since v6.5): https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/clock/qcom,sc8280xp-lpasscc.yaml I will contact ARM & Lenovo to see if this issue can be fixed in later releases. (In reply to Chester Lin from comment #6) > (In reply to Jiri Slaby from comment #5) > > (In reply to Chester Lin from comment #2) > > > The UEFI firmware of X13s has clk DT overlays that do not match the upstream > > > DT (See as below example). Here we will need a downstream patch in order to > > > enable audio system (LPASS) on X13s. > > > > So how is this going to be handled in upstream? IOW, why do we need a > > downstream patch and keep upstream broken? > > I think this issue must be fixed in Lenovo UEFI firmware since Lenovo should > follow the upstream dt-bindings (since v6.5): > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/ > Documentation/devicetree/bindings/clock/qcom,sc8280xp-lpasscc.yaml > > I will contact ARM & Lenovo to see if this issue can be fixed in later > releases. The compatible mismatch issue is now fixed in X13s UEFI FW v1.58. (In reply to Chester Lin from comment #7) > (In reply to Chester Lin from comment #6) > > (In reply to Jiri Slaby from comment #5) > > > (In reply to Chester Lin from comment #2) > > > > The UEFI firmware of X13s has clk DT overlays that do not match the upstream > > > > DT (See as below example). Here we will need a downstream patch in order to > > > > enable audio system (LPASS) on X13s. > > > > > > So how is this going to be handled in upstream? IOW, why do we need a > > > downstream patch and keep upstream broken? > > > > I think this issue must be fixed in Lenovo UEFI firmware since Lenovo should > > follow the upstream dt-bindings (since v6.5): > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/ > > Documentation/devicetree/bindings/clock/qcom,sc8280xp-lpasscc.yaml > > > > I will contact ARM & Lenovo to see if this issue can be fixed in later > > releases. > > The compatible mismatch issue is now fixed in X13s UEFI FW v1.58. I have dropped the workaround patch of lpasscc and confirmed that all QCOM EFI patches will be applied in v6.7-rc1. Let's close this bug, thank you. |