Bug 1216026

It's a 'recommends', if someone goes out of their way to disable those - not sure how many people do, I don't - then _maybe_ that argument can be made.

$ rpm -q --recommends kitty
kitty-shell-integration
kitty-terminfo
python3-importlib-resources

recommends can be disabled. and yes I do. having the proper terminfo file is probably required for kitty to work properly no?

so that should probably be a require.

If you chose to disable 'recommends', I feel you've chosen to live with the concept of 'I should check what's recommended and decide if I feel it should be installed' - that's the point of doing it that way, I'd assume.

If 'kitty-terminfo' wasn't mentioned at all, I'd be inclined to simply add it as a 'requires' - but making a change (albeit a simple one) to accomodate those that have disabled recommends doesn't seem necessary, if it _always_ was, then what's the point in the distinction between 'recommends' and 'requires'?

Revisiting the existence of 'kitty-terminfo' - which didn't exist as a separate package until the not-too-distant past (prior 'kitty' was an all-in-one package) - it isn't 'required' if all you want is to use /usr/bin/kitty on the machine you're physically in front of. 'kitty' (the package) includes /usr/lib64/kitty/terminfo/x/xterm-kitty, so functionality shouldn't be an issue. I believe the main point of 'kitty-terminfo' is to provide /usr/share/terminfo/x/xterm-kitty for systems that aren't being used in the 'I'm sitting right in front of it' sense, i.e. ssh'ing into a remote host.

this is not where ncurses looks for the file /usr/lib64/kitty/terminfo/x/xterm-kitty

so this can probably be deleted.

you want the requires.

(In reply to Marcus Rückert from comment #4)
> this is not where ncurses looks for the file
> /usr/lib64/kitty/terminfo/x/xterm-kitty
> 
> so this can probably be deleted.
> 

Can you provide some type of evidence of this (and its implications, honestly I'm not sure what ncurses directly has to do w/ this RPM for kitty)? If I move /usr/lib64/kitty/terminfo/x/xterm-kitty -> /usr/lib64/kitty/terminfo/x/xterm-kitty.orig, I get this message at the next kitty launch:

warning: Could not set up terminal.
warning: TERM environment variable set to 'xterm-kitty'.
warning: Check that this terminal type is supported on this system.
warning: Using fallback terminal type 'xterm-256color'.

> you want the requires.

In your opinion; I'm not seeing _proof_ why that would be so other than your preference for disabling recommends. I'm not morally opposed to adding it, I just don't see the need. I can have 'kitty' & 'kitty-shell-integration' on the host I'm sitting in front of and just 'kitty-terminfo' on a remote host w/o issue - both hosts report `TERM=xterm-kitty` and function fine.