Bug 1216311

Summary:	VUL-0: CVE-2023-45683: teleport: github.com/crewjam/saml: XSS via missing Binding syntax validation
Product:	[openSUSE] openSUSE Distribution	Reporter:	SMASH SMASH <smash_bz>
Component:	Security	Assignee:	Security Team bot <security-team>
Status:	RESOLVED FIXED	QA Contact:	Security Team bot <security-team>
Severity:	Major
Priority:	P3 - Medium	CC:	gabriele.sonnu, opensuse_buildservice
Version:	Leap 15.6
Target Milestone:	---
Hardware:	Other
OS:	Other
URL:	https://smash.suse.de/issue/382019/
Whiteboard:	CVSSv3.1:SUSE:CVE-2023-45683:7.1:(AV:N/AC:L/PR:N/UI:R/S:C/C:L/I:L/A:L)
Found By:	Security Response Team	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Bug Depends on:
Bug Blocks:	1216308

Description SMASH SMASH 2023-10-17 08:05:51 UTC

Impact

The package does not validate the ACS Location URI according to the SAML binding being parsed.

If abused, this flaw allows attackers to register malicious Service Providers at the IdP and inject Javascript in the ACS endpoint definition, achieving Cross-Site-Scripting (XSS) in the IdP context during the redirection at the end of a SAML SSO Flow.

Consequently, an attacker may perform any authenticated action as the victim once the victim’s browser loaded the SAML IdP initiated SSO link for the malicious service provider.

Note: The severity is considered “High” because the SP registration is commonly an unrestricted operation in IdPs, hence not requiring particular permissions or publicly accessible to ease the IdP interoperability.

Patches

This issue is fixed in 0.4.14

Workarounds

Users of the package can perform external validation of URLs provided in SAML metadata, or restrict the ability for end-users to upload arbitrary metadata.

References:
https://github.com/crewjam/saml/security/advisories/GHSA-267v-3v32-g6q5
http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2023-45683

References:
http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2023-45683

Comment 1 Gabriele Sonnu 2023-10-17 08:18:27 UTC

github.com/crewjam/saml is embedded in:

- openSUSE:Factory/teleport (github.com/crewjam/saml v0.4.12)

Comment 2 Johannes Kastl 2023-10-24 14:16:48 UTC

I went back as far as teleport 13.3.8, which was sent to Factory beginning of September. This already had "github.com/crewjam/saml v0.4.14-0.20230420111643-34930b26d33b" in the go.mod file.

So I daresay this should already be fixed in Tumbleweed.

But the issue says something regarding 15.6, not sure which version is included in Leap 15.6.

Kind Regards
Johannes

Comment 4 Gabriele Sonnu 2024-01-24 16:37:16 UTC

All fixed, closing.