Bug 1216814

Summary:	/sbin/dhclient-script (dhcp-client) requires usleep (sysvinit-tools)
Product:	[openSUSE] openSUSE Tumbleweed	Reporter:	Petr Vorel <petr.vorel>
Component:	Network	Assignee:	Jorik Cronenberg <jorik.cronenberg>
Status:	RESOLVED WONTFIX	QA Contact:	E-mail List <qa-bugs>
Severity:	Normal
Priority:	P5 - None	CC:	kukuk, mt
Version:	Current
Target Milestone:	---
Hardware:	Other
OS:	Other
See Also:	https://bugzilla.suse.com/show_bug.cgi?id=1216822
Whiteboard:
Found By:	---	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---

Description Petr Vorel 2023-11-02 10:14:50 UTC

I'm not sure if NetworkManager or wicked use /sbin/dhclient-script, but if we ship it, it should work. i.e. we should add dependency to sysvinit-tools, which contains usleep.

Found by LTP ltp_net_ipv6 tests which tries to use dhcpd and dnsmasq on IPv6 and use for that dhclient-script (not a realistic scenario):
http://quasar.suse.cz/tests/3065#step/dhcpd6/8
/sbin/dhclient-script: line 393: usleep: command not found

http://quasar.suse.cz/tests/3065#step/dnsmasq6/8
/sbin/dhclient-script: line 393: usleep: command not found

Comment 1 Thorsten Kukuk 2023-11-02 13:29:03 UTC

(In reply to Petr Vorel from comment #0)
> I'm not sure if NetworkManager or wicked use /sbin/dhclient-script

Nobody is using it, it's unsupported:

# Note:
#   It is used by sysconfig alias netcontrol alias ifup-dhcp,
#   but not by the NetworkManager that is using an own script.
#
#   Wicked is using an another dhcp client (runtime conflict).
#   As sysconfig-network is gone on sles12 and opensuse > 13.1,
#   this script is obsolete and unsupported.


> but if we ship it, it should work.

We should not ship scripts which are obsolete, unsupported and unused by our stack.
So it should be removed from dhcp-client package.

> i.e. we should add dependency to sysvinit-tools, which contains usleep.

This will not pass any review, as sysvinit-tools is clearly deprecated.

Comment 2 Petr Vorel 2023-11-02 13:32:07 UTC

(In reply to Thorsten Kukuk from comment #1)
> > but if we ship it, it should work.
> 
> We should not ship scripts which are obsolete, unsupported and unused by our
> stack.
> So it should be removed from dhcp-client package.

Thanks for feedback. It makes sense, I'll remove it.

Comment 3 Petr Vorel 2023-11-02 13:50:48 UTC

Replaced by https://bugzilla.suse.com/show_bug.cgi?id=1216822.

@Marius feel free to reopen this and close #1216822 if it should be kept.