Bug 1217004

Summary: obs-service-source_validator warns on Debian bash-completion file
Product: [Internal Novell Products] openSUSE Build Service Reporter: John Serock <john.serock>
Component: source servicesAssignee: Adrian Schröter <adrian.schroeter>
Status: NEW --- QA Contact: Adrian Schröter <adrian.schroeter>
Severity: Normal    
Priority: P5 - None    
Version: master   
Target Milestone: ---   
Hardware: x86-64   
OS: openSUSE Leap 15.5   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: Modified source validator

Description John Serock 2023-11-09 23:31:54 UTC
Created attachment 870700 [details]
Modified source validator

Overview:

    Building a Debian package that contains a bash completion and defines the source_validation service in its _service file, and has OBS use the debtransform tool, causes the obs-service-source_validator to produce a warning message. 

Steps to Reproduce:

    1) Add a debian.<packageName>.bash-completion file to the package to be built.
       The man page for dh_bash-completion describes the contents of the debian/<packageName>.bash-completion file. 

    2) osc build --local-package Debian_12 x86_64

Actual Results:

    The obs-service-source_validator produces the following warning message:

    (W) Attention, debian.<packageName>.bash-completion is not mentioned in spec files as source or patch.

Expected Results:

    The obs-service-source_validator should ignore the debian.<packageName>.bash-completion file as it does for other debian files, like debian.<packageName>.preinst and not produce a warning message.

Build:

    obs-service-source_validator 0.25-150000.3.3.1 on openSUSE Leap 15.5

Additional Information:

    Changing /usr/lib/obs/service/source_validators/20-files-present-and-referenced on my system to ignore debian.*.bash-completion resolves the issue. See line 329 in the modified source validator attachment.