Bug 1218290

Summary: The world is not ready for FreeRDP 3
Product: [openSUSE] openSUSE Tumbleweed Reporter: Dominique Leuenberger <dimstar>
Component: X11 ApplicationsAssignee: Johannes Weberhofer <jweberhofer>
Status: NEW --- QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P3 - Medium CC: ana.guerrero, fvogt, hp.jansen, hpj, joan.torres
Version: Current   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description Dominique Leuenberger 2023-12-21 07:42:48 UTC
freerdp was attempted to be upgraded to version 3.

This causes quite a lot of build issues:

gamescope
      nothing provides pkgconfig(freerdp2)
gnome-connections
      nothing provides pkgconfig(freerdp2) >= 2.0.0
gnome-remote-desktop
      nothing provides pkgconfig(freerdp-client2) >= 2.10.0
      nothing provides pkgconfig(freerdp-server2) >= 2.10.0
      nothing provides pkgconfig(freerdp2) >= 2.10.0
pidgin-sipe
      nothing provides pkgconfig(freerdp-shadow2)
remmina
      nothing provides pkgconfig(freerdp2) >= 2.1.0
weston
      nothing provides pkgconfig(freerdp2)
wlroots
      nothing provides pkgconfig(freerdp2)
wlroots-0_16
      nothing provides pkgconfig(freerdp2)
wlroots10
      nothing provides pkgconfig(freerdp2)

This is a bit too much breakage in the old yea
Comment 1 Dominique Leuenberger 2023-12-21 08:12:20 UTC
one viable option is to have freerdp 3 plus freerdp2 compact packages
Comment 2 Johannes Weberhofer 2023-12-21 10:29:58 UTC
Please see my my comment at https://build.opensuse.org/request/show/1133016

Yes, I think, all the changes should be rolled back and a new freerdp3 project should be created.
Comment 3 Johannes Weberhofer 2023-12-21 10:32:51 UTC
For such huge changes I would not expect to accept changes in a package without former discussions or at least waiting for the maintainers to agree.
Comment 4 Dominique Leuenberger 2023-12-21 10:40:15 UTC
(In reply to Johannes Weberhofer from comment #3)
> For such huge changes I would not expect to accept changes in a package
> without former discussions or at least waiting for the maintainers to agree.

well, the submission to Factory was done by a Maintainer... Sad to see that the different maintainers did not get to a conclusion before one of them submitted it

in any case: Factory is reverted to the last freerdp package we had, in order to gain some time
Comment 5 Hans-Peter Jansen 2023-12-21 11:42:49 UTC
(In reply to Dominique Leuenberger from comment #4)
> (In reply to Johannes Weberhofer from comment #3)
> > For such huge changes I would not expect to accept changes in a package
> > without former discussions or at least waiting for the maintainers to agree.
> 
> well, the submission to Factory was done by a Maintainer... Sad to see that
> the different maintainers did not get to a conclusion before one of them
> submitted it
> 
> in any case: Factory is reverted to the last freerdp package we had, in
> order to gain some time

Yeah, I feel guilty. 

Thanks for the revert, Dominique.

@Johannes, I worked with Fabian on this package, and it's in a pretty good shape already. Not sure, if I manage to split a freerdp2 package over the holidays.

Let's delay the submission of version 3, until this is done.
Comment 6 Fabian Vogt 2023-12-21 17:10:04 UTC
FTR, I only forwarded the SR to oS:F because there was already a SR for freerdp 3 pending (https://build.opensuse.org/request/show/1133890).
Comment 7 Johannes Weberhofer 2023-12-22 10:13:07 UTC
Thank you, Hans-Peter and Dominique for your efforts!

I have just now submitted a new freerdp3 package to the development project: https://build.opensuse.org/request/show/1134611

The current freerdp package can be rolled back to revision 156 after the new project has been accepted.

Have nice holidays!
Comment 8 Hans-Peter Jansen 2023-12-22 14:56:32 UTC
(In reply to Johannes Weberhofer from comment #7)
> Thank you, Hans-Peter and Dominique for your efforts!
> 
> I have just now submitted a new freerdp3 package to the development project:
> https://build.opensuse.org/request/show/1134611

Thanks, Johannes, but as Dominique mentioned already, this will not be going to fly. 
We will need to create a freerdp2 package, where libraries do coexist properly. 
The devel-packages can (and probably should) conflict.
Then, we can submit the current freerdp just fine. 
 
> The current freerdp package can be rolled back to revision 156 after the new
> project has been accepted.
> 
> Have nice holidays!

Happy holidays for you, too!
Comment 9 Johannes Weberhofer 2023-12-22 16:37:37 UTC
I would do it vice versa. Leaving the old package and add a new freerdp3 package. Would things make more easier when new versions will be released.
Comment 10 Dominique Leuenberger 2023-12-22 20:33:12 UTC
(In reply to Johannes Weberhofer from comment #9)
> I would do it vice versa. Leaving the old package and add a new freerdp3
> package. Would things make more easier when new versions will be released.

The package guidelines are quite clear on this:
the principal name (without version suffix) is the latest version. Compat versions are suffixed.

The idea is rather clear: the latest version is supposed to stick around and the compact is supposed to be eliminated over time

https://en.opensuse.org/openSUSE:Package_naming_guidelines#Multiple_packages_for_the_same_software
When providing multiple versions of a software, the package name should reflect this fact. The package with the most recent version should use the principal name with no versions and all other addons should note their version in the name.
Comment 11 Joan Torres 2024-03-15 11:21:21 UTC
Hi. I would like to push this forward.

The gnome-remote-version 46 will depend on FreeRDP3.

Here I've created a SR adding freerdp2, and another one for freerdp to drop conflicts:

https://build.opensuse.org/request/show/1158205
https://build.opensuse.org/request/show/1158206