Bug 1218367

Summary: kalpa-firstboot crashes after fresh install
Product: [openSUSE] openSUSE Kalpa Reporter: Vincent Koppen <vincent+suse>
Component: BaseAssignee: Shawn Dunn <sfalken>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Major    
Priority: P2 - High CC: robin.shepheard
Version: Current   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: fixed kalpa-firstboot

Description Vincent Koppen 2023-12-22 23:23:54 UTC 
Created attachment 871540 [details]
fixed kalpa-firstboot

Just did a fresh install of openSUSE Kalpa and the firstboot script (for installing the flatpak packages) crashed. 

To fix this I applied the following changes to kalpa-firstboot, see also the attached file. 
I tested it by copying /usr/bin/kalpa-firstboot to my home directory, edited there as below and than ran it from the terminal.

>diff kalpa-firstboot /usr/bin/kalpa-firstboot 
>>10c10
><     qdbus-qt5 $dbusRef setLabelText "$label"
>---
>>     qdbus-qt5 "$dbusRef" setLabelText "$label"
>12,13c12,13
><     if eval "$@"; then
><         qdbus-qt5 $dbusRef value "$step"
>---
>>     if "$@"; then
>>         qdbus-qt5 "$dbusRef" Set "" value "$step"
>21c21
>< run_task 2 "Adding Flathub Repository" /usr/bin/flatpak remote-add --user >--if-not-exists flathub /usr/share/kalpa/flathub.flatpakrepo
>---
>> run_task 2 "Adding Flathub Repository" /usr/bin/flatpak remote-add --user >--if-not-exists flathub /usr/share/microos-desktop/flathub.flatpakrepo
>30c30
>< qdbus-qt5 $dbusRef close
>---
>> qdbus-qt5 "$dbusRef" close
Comment 2 Robin Shepheard 2023-12-27 18:48:09 UTC 
The patch is still failing. Having copied the changes made by Vincent to a local file in home and running diff I get the following:-

diff ./kalpa-firstboot /usr/bin/kalpa-firstboot 
12c12
<     if eval "$@"; then
---
>     if "$@"; then

as soon as the eval is added in it runs without error
Comment 3 Shawn Dunn 2023-12-27 18:52:17 UTC 
(In reply to Robin Shepheard from comment #2)
> The patch is still failing. Having copied the changes made by Vincent to a
> local file in home and running diff I get the following:-
> 
> diff ./kalpa-firstboot /usr/bin/kalpa-firstboot 
> 12c12
> <     if eval "$@"; then
> ---
> >     if "$@"; then
> 
> as soon as the eval is added in it runs without error

Just pushed the changes with the eval added, please give it a try
Comment 4 Vincent Koppen 2023-12-28 11:09:53 UTC 
(In reply to Shawn Dunn from comment #3)
> (In reply to Robin Shepheard from comment #2)
> > The patch is still failing. Having copied the changes made by Vincent to a
> > local file in home and running diff I get the following:-
> > 
> > diff ./kalpa-firstboot /usr/bin/kalpa-firstboot 
> > 12c12
> > <     if eval "$@"; then
> > ---
> > >     if "$@"; then
> > 
> > as soon as the eval is added in it runs without error
> 
> Just pushed the changes with the eval added, please give it a try

Installed the 5.1 rpm (https://download.opensuse.org/repositories/devel:/microos:/kalpa/openSUSE_Tumbleweed/noarch/plasma-branding-Kalpa-20231227-5.1.noarch.rpm) in a fresh install and after that everything worked as expected!
Comment 5 Shawn Dunn 2023-12-28 17:56:29 UTC 
Submitted to Factory for review:

https://build.opensuse.org/request/show/1135523
Comment 6 Shawn Dunn 2024-02-01 20:53:50 UTC 
Accepted into Factory a while ago, I'm just slow.